New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 660028 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Remove "X" when waiting for the website to process payment in Payment Request.

Project Member Reported by se...@chromium.org, Oct 27 2016

Issue description

Right now we show the X button so it's possible for a user to click it after the payment info have been sent to the merchant. This should not be possible.
 

Comment 1 by se...@chromium.org, Oct 27 2016

Cc: hwi@chromium.org rouslan@chromium.org zkoch@chromium.org
+Hwi

Here is what I've done so far, but I feel it's not a great UI to just have the X dissapear when we've sent the info to the merchant.

BTW I have added a 2seconds delay to both
- processing the info on our side (still cancelable)
- waiting for the merchant response (not cancelable)
so the change is more visible. For cards, the first part would probably not be visible at all but I think eventually Payment apps might take longer.


before.mp4
2.4 MB View Download
after.mp4
2.3 MB View Download
The "X" should disappear the moment you see "Loading" with a spinner. I understand that the data is not sent to the merchant immediately when "Loading" shows up, but that's an  implementation detail.

Comment 3 by se...@chromium.org, Oct 27 2016

Oh much easier then. Thanks.

Comment 4 by se...@chromium.org, Oct 27 2016

Here is the new UI, both in real speed and with a delay.
real_speed.mp4
2.4 MB View Download
with_delay.mp4
1.9 MB View Download
👍
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01f556eda522112d177831dba13af274c2af4be2

commit 01f556eda522112d177831dba13af274c2af4be2
Author: sebsg <sebsg@chromium.org>
Date: Thu Oct 27 18:08:38 2016

[Payments] Remove the X in payments request processing UI.

BUG= 660028 

Review-Url: https://codereview.chromium.org/2461443002
Cr-Commit-Position: refs/heads/master@{#428078}

[modify] https://crrev.com/01f556eda522112d177831dba13af274c2af4be2/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Comment 7 by se...@chromium.org, Oct 27 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Works as per expected behavior,"X" disappears the moment when we see "Loading" with a spinner .
Issue tested on Latest M56 Build.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment