New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Compat
M56

Blocking:
issue 809688



Sign in to add a comment

Custom properties can't be updated within ::first-letter

Reported by gwhi...@gmail.com, Oct 27 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.14956

Example URL:
http://jsbin.com/nutuwekoza/edit?html,css,output

Steps to reproduce the problem:
1. Open the jsbin

What is the expected behavior?
The first letter in the word 'Div' should be orange.

What went wrong?
The variable definition wasn't updated within the first-letter pseudo for some reason, they are applied but not updated.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 54.0.2840.71  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0

This works as expected in FF.
 
Labels: M56 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on windows 7,Mac 10.11.4,Ubuntu 14.04 using chrome version #54.0.2840.71,latest canary #56.0.2906.0 as blue color DIV text observed.

This is a non regression issue as Black color 'DIV' text observed in M30,M45 ,M48 old buils .

Hence, marking it as Untriaged to get more inputs from dev team.

Thanks,
adding more info:

Issue (blue color DIV) observed from M49 to Latest stable & Canary.
Components: Blink>CSS

Comment 4 by timloh@chromium.org, Jan 17 2017

We have a whitelist isValidFirstLetterStyleProperty(CSSPropertyID id), maybe we should just allow custom properties? I don't recall where the list comes from.

Comment 5 by nainar@chromium.org, Jan 18 2017

Labels: Hotlist-Interop
Status: Available (was: Untriaged)
Labels: Update-Quarterly

Comment 7 by meade@chromium.org, Oct 31 2017

Labels: Code-Resolver Hotlist-GoodFirstBug
Labels: -Update-Quarterly
Blocking: 809688
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d91e2685675f4dd22dc3a3356a154c2eea7cef

commit e9d91e2685675f4dd22dc3a3356a154c2eea7cef
Author: Chris Nardi <cnardi@chromium.org>
Date: Wed Feb 07 17:45:24 2018

Update list of properties whitelisted for first-letter

CSS Pseudo 4 [1] expands the list of properties that can apply to
::first-letter when compared to CSS Selectors 3. Our list was based
primarily off of CSS Selectors 3; update per Pseudo 4. Also whitelist
variables within ::first-letter.

[1]: https://drafts.csswg.org/css-pseudo-4/#first-letter-styling

Bug:  660026 ,  715661 
Change-Id: I950c7881506f8c36c3b917aff0ed2f1709d194ce
Reviewed-on: https://chromium-review.googlesource.com/899859
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535045}
[add] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-property-whitelist.html
[delete] https://crrev.com/5252152ed10bd12bfe8544859e5bae1708906a19/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-letter-expected.txt
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/all-shorthand-first-letter-expected.html
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/all-shorthand-first-letter.html
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/first-letter-property-whitelist.html
[modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Owner: cnardi@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment