Custom properties can't be updated within ::first-letter
Reported by
gwhi...@gmail.com,
Oct 27 2016
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.14956 Example URL: http://jsbin.com/nutuwekoza/edit?html,css,output Steps to reproduce the problem: 1. Open the jsbin What is the expected behavior? The first letter in the word 'Div' should be orange. What went wrong? The variable definition wasn't updated within the first-letter pseudo for some reason, they are applied but not updated. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 54.0.2840.71 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 This works as expected in FF.
,
Nov 1 2016
adding more info: Issue (blue color DIV) observed from M49 to Latest stable & Canary.
,
Jan 17 2017
,
Jan 17 2017
We have a whitelist isValidFirstLetterStyleProperty(CSSPropertyID id), maybe we should just allow custom properties? I don't recall where the list comes from.
,
Jan 18 2017
,
Feb 13 2017
,
Oct 31 2017
,
Dec 6 2017
,
Feb 6 2018
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9d91e2685675f4dd22dc3a3356a154c2eea7cef commit e9d91e2685675f4dd22dc3a3356a154c2eea7cef Author: Chris Nardi <cnardi@chromium.org> Date: Wed Feb 07 17:45:24 2018 Update list of properties whitelisted for first-letter CSS Pseudo 4 [1] expands the list of properties that can apply to ::first-letter when compared to CSS Selectors 3. Our list was based primarily off of CSS Selectors 3; update per Pseudo 4. Also whitelist variables within ::first-letter. [1]: https://drafts.csswg.org/css-pseudo-4/#first-letter-styling Bug: 660026 , 715661 Change-Id: I950c7881506f8c36c3b917aff0ed2f1709d194ce Reviewed-on: https://chromium-review.googlesource.com/899859 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#535045} [add] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/external/wpt/css/css-pseudo/first-letter-property-whitelist.html [delete] https://crrev.com/5252152ed10bd12bfe8544859e5bae1708906a19/third_party/WebKit/LayoutTests/external/wpt/css/css-variables/variable-first-letter-expected.txt [modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/all-shorthand-first-letter-expected.html [modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/all-shorthand-first-letter.html [modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/LayoutTests/fast/css/first-letter-property-whitelist.html [modify] https://crrev.com/e9d91e2685675f4dd22dc3a3356a154c2eea7cef/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
,
Feb 7 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jmukthavaram@chromium.org
, Nov 1 2016Status: Untriaged (was: Unconfirmed)