New issue
Advanced search Search tips

Issue 660015 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 658627



Sign in to add a comment

libFuzzer compile failure on all platforms

Project Member Reported by aarya@google.com, Oct 27 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan/builds/11286
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan/builds/11287/steps/compile/logs/stdio

Looks like autoroller has latest pdfium commits. Recent breakage from yesterday. I think Tom had some patches in this.

[345/394] CXX obj/third_party/pdfium/testing/libfuzzer/pdf_codec_tiff_fuzzer/pdf_codec_tiff_fuzzer.o
FAILED: obj/third_party/pdfium/testing/libfuzzer/pdf_codec_tiff_fuzzer/pdf_codec_tiff_fuzzer.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/testing/libfuzzer/pdf_codec_tiff_fuzzer/pdf_codec_tiff_fuzzer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DSANITIZER_COVERAGE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../third_party/pdfium -I../../third_party/pdfium/third_party/freetype/include -I../../third_party/pdfium/third_party/freetype/include/freetype -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O1 -gdwarf-2 -fno-standalone-debug -isysroot /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.8 -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize-coverage=edge,indirect-calls,8bit-counters -mllvm -sanitizer-coverage-prune-blocks=1 -fsanitize=address -mllvm -asan-globals=0 -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c ../../third_party/pdfium/testing/libfuzzer/pdf_codec_tiff_fuzzer.cc -o obj/third_party/pdfium/testing/libfuzzer/pdf_codec_tiff_fuzzer/pdf_codec_tiff_fuzzer.o
In file included from ../../third_party/pdfium/testing/libfuzzer/pdf_codec_tiff_fuzzer.cc:5:
../../third_party/pdfium/testing/libfuzzer/xfa_codec_fuzzer.h:51:13: error: virtual function 'ReadBlock' has a different return type ('FX_BOOL' (aka 'int')) than the function it overrides (which has return type 'bool')
    FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
    ~~~~~~~ ^
../../third_party/pdfium/core/fxcrt/fx_stream.h:94:16: note: overridden virtual function is here
  virtual bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) = 0;
          ~~~~ ^
1 error generated.
[346/394] CXX obj/third_party/pdfium/testing/libfuzzer/pdf_codec_png_fuzzer/pdf_codec_png_fuzzer.o
FAILED: obj/third_party/pdfium/testing/libfuzzer/pdf_codec_png_fuzzer/pdf_codec_png_fuzzer.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/testing/libfuzzer/pdf_codec_png_fuzzer/pdf_codec_png_fuzzer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DSANITIZER_COVERAGE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../third_party/pdfium -I../../third_party/pdfium/third_party/freetype/include -I../../third_party/pdfium/third_party/freetype/include/freetype -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O1 -gdwarf-2 -fno-standalone-debug -isysroot /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.8 -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize-coverage=edge,indirect-calls,8bit-counters -mllvm -sanitizer-coverage-prune-blocks=1 -fsanitize=address -mllvm -asan-globals=0 -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c ../../third_party/pdfium/testing/libfuzzer/pdf_codec_png_fuzzer.cc -o obj/third_party/pdfium/testing/libfuzzer/pdf_codec_png_fuzzer/pdf_codec_png_fuzzer.o
In file included from ../../third_party/pdfium/testing/libfuzzer/pdf_codec_png_fuzzer.cc:5:
../../third_party/pdfium/testing/libfuzzer/xfa_codec_fuzzer.h:51:13: error: virtual function 'ReadBlock' has a different return type ('FX_BOOL' (aka 'int')) than the function it overrides (which has return type 'bool')
    FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
    ~~~~~~~ ^
../../third_party/pdfium/core/fxcrt/fx_stream.h:94:16: note: overridden virtual function is here
  virtual bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) = 0;
          ~~~~ ^
1 error generated.
[347/394] CXX obj/third_party/pdfium/testing/libfuzzer/pdf_codec_bmp_fuzzer/pdf_codec_bmp_fuzzer.o
FAILED: obj/third_party/pdfium/testing/libfuzzer/pdf_codec_bmp_fuzzer/pdf_codec_bmp_fuzzer.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/testing/libfuzzer/pdf_codec_bmp_fuzzer/pdf_codec_bmp_fuzzer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DSANITIZER_COVERAGE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../third_party/pdfium -I../../third_party/pdfium/third_party/freetype/include -I../../third_party/pdfium/third_party/freetype/include/freetype -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O1 -gdwarf-2 -fno-standalone-debug -isysroot /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.8 -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize-coverage=edge,indirect-calls,8bit-counters -mllvm -sanitizer-coverage-prune-blocks=1 -fsanitize=address -mllvm -asan-globals=0 -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c ../../third_party/pdfium/testing/libfuzzer/pdf_codec_bmp_fuzzer.cc -o obj/third_party/pdfium/testing/libfuzzer/pdf_codec_bmp_fuzzer/pdf_codec_bmp_fuzzer.o
In file included from ../../third_party/pdfium/testing/libfuzzer/pdf_codec_bmp_fuzzer.cc:5:
../../third_party/pdfium/testing/libfuzzer/xfa_codec_fuzzer.h:51:13: error: virtual function 'ReadBlock' has a different return type ('FX_BOOL' (aka 'int')) than the function it overrides (which has return type 'bool')
    FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
    ~~~~~~~ ^
../../third_party/pdfium/core/fxcrt/fx_stream.h:94:16: note: overridden virtual function is here
  virtual bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) = 0;
          ~~~~ ^
1 error generated.
[348/394] CXX obj/third_party/pdfium/testing/libfuzzer/pdf_codec_gif_fuzzer/pdf_codec_gif_fuzzer.o
FAILED: obj/third_party/pdfium/testing/libfuzzer/pdf_codec_gif_fuzzer/pdf_codec_gif_fuzzer.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/testing/libfuzzer/pdf_codec_gif_fuzzer/pdf_codec_gif_fuzzer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DSANITIZER_COVERAGE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../third_party/pdfium -I../../third_party/pdfium/third_party/freetype/include -I../../third_party/pdfium/third_party/freetype/include/freetype -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O1 -gdwarf-2 -fno-standalone-debug -isysroot /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.8 -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize-coverage=edge,indirect-calls,8bit-counters -mllvm -sanitizer-coverage-prune-blocks=1 -fsanitize=address -mllvm -asan-globals=0 -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c ../../third_party/pdfium/testing/libfuzzer/pdf_codec_gif_fuzzer.cc -o obj/third_party/pdfium/testing/libfuzzer/pdf_codec_gif_fuzzer/pdf_codec_gif_fuzzer.o
In file included from ../../third_party/pdfium/testing/libfuzzer/pdf_codec_gif_fuzzer.cc:5:
../../third_party/pdfium/testing/libfuzzer/xfa_codec_fuzzer.h:51:13: error: virtual function 'ReadBlock' has a different return type ('FX_BOOL' (aka 'int')) than the function it overrides (which has return type 'bool')
    FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
    ~~~~~~~ ^
../../third_party/pdfium/core/fxcrt/fx_stream.h:94:16: note: overridden virtual function is here
  virtual bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) = 0;
          ~~~~ ^
1 error generated.
[349/394] CXX obj/third_party/pdfium/testing/libfuzzer/pdf_codec_jpeg_fuzzer/pdf_codec_jpeg_fuzzer.o
FAILED: obj/third_party/pdfium/testing/libfuzzer/pdf_codec_jpeg_fuzzer/pdf_codec_jpeg_fuzzer.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/testing/libfuzzer/pdf_codec_jpeg_fuzzer/pdf_codec_jpeg_fuzzer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DSANITIZER_COVERAGE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../third_party/pdfium -I../../third_party/pdfium/third_party/freetype/include -I../../third_party/pdfium/third_party/freetype/include/freetype -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O1 -gdwarf-2 -fno-standalone-debug -isysroot /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.8 -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize-coverage=edge,indirect-calls,8bit-counters -mllvm -sanitizer-coverage-prune-blocks=1 -fsanitize=address -mllvm -asan-globals=0 -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -c ../../third_party/pdfium/testing/libfuzzer/pdf_codec_jpeg_fuzzer.cc -o obj/third_party/pdfium/testing/libfuzzer/pdf_codec_jpeg_fuzzer/pdf_codec_jpeg_fuzzer.o
In file included from ../../third_party/pdfium/testing/libfuzzer/pdf_codec_jpeg_fuzzer.cc:5:
../../third_party/pdfium/testing/libfuzzer/xfa_codec_fuzzer.h:51:13: error: virtual function 'ReadBlock' has a different return type ('FX_BOOL' (aka 'int')) than the function it overrides (which has return type 'bool')
    FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override {
    ~~~~~~~ ^
../../third_party/pdfium/core/fxcrt/fx_stream.h:94:16: note: overridden virtual function is here
  virtual bool ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) = 0;
          ~~~~ ^
1 error generated.
 

Comment 1 by npm@chromium.org, Oct 27 2016

Cc: -tsepez@chromium.org dsinclair@chromium.org
Owner: tsepez@chromium.org

Comment 2 by tsepez@chromium.org, Oct 27 2016

Status: Started (was: Assigned)
https://codereview.chromium.org/2452523005/
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2194d3b9eb2519c25275ac19f8fb68d4d4ac4164

commit 2194d3b9eb2519c25275ac19f8fb68d4d4ac4164
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Oct 27 17:51:10 2016

Roll src/third_party/pdfium/ 1c467483d..aeab530b0 (1 commit).

https://pdfium.googlesource.com/pdfium.git/+log/1c467483d806..aeab530b0493

$ git log 1c467483d..aeab530b0 --date=short --no-merges --format='%ad %ae %s'
2016-10-27 tsepez Fix libfuzzer build broken at 9f7f7f8

BUG= 660015 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2457583004
Cr-Commit-Position: refs/heads/master@{#428073}

[modify] https://crrev.com/2194d3b9eb2519c25275ac19f8fb68d4d4ac4164/DEPS

Sign in to add a comment