New issue
Advanced search Search tips

Issue 660011 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Back & Close navigation buttons aren't disabled by dialogs in Enterprise Enrollment flow

Project Member Reported by glevin@chromium.org, Oct 27 2016

Issue description

Version: 56.0.2902.0

What steps will reproduce the problem?
(1) At initial Sign in, switch to Enterprise Enrollment (CTRL+ALT+E)
(2) Open a modal dialog, like More options > Learn more

What is the expected output?
The close (and back, if present) button should be disabled.

What do you see instead?
The buttons are still enabled.

This works on the regular Sign in flow.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652240f3d4404a949aaa0a9ca04017bd25011958

commit 652240f3d4404a949aaa0a9ca04017bd25011958
Author: glevin <glevin@chromium.org>
Date: Fri Oct 28 01:33:24 2016

Fix login navigation button enabling

BUG= 658014 , 660011 
TEST=Back, Close, and Refresh buttons should always be disabled when a
modal dialog is present, and enabled otherwise.  See bugs for specific
repro instructions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2452333003
Cr-Commit-Position: refs/heads/master@{#428231}

[modify] https://crrev.com/652240f3d4404a949aaa0a9ca04017bd25011958/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/652240f3d4404a949aaa0a9ca04017bd25011958/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Comment 2 by glevin@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)

Comment 3 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Components: Enterprise

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
As verified in M60.0.3112.39:9592.27.0 elm beta, the fix works according to the described behavior -- the Close (X) button on the top right of enrollment dialog is disabled when the modal dialog is present.

Technically, a modal dialog is a window that forces the user to interact with it before they can go back to using the parent application.

However, during the present of the modal dialog triggered by More options > Learn more, other components such as Shut down, Browse as a guest, change input method, Accessibility, change network are still accessible to the user. A true modal dialog should freeze everything else until it is closed.

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment