New issue
Advanced search Search tips

Issue 660007 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
V1

Blocked on:
issue 659645



Sign in to add a comment

authpolicy: Add unit tests to preg_parser and registry_dict.

Project Member Reported by ljusten@chromium.org, Oct 27 2016

Issue description

Wait until 659645 ("authpolicy: Fix preg_parser and registry_dict maintainance issues") is implemented and reuse tests from Chromium.

Also, add a fuzzer test.
 
Description: Show this description
Labels: Enterprise-Triaged

Comment 3 by tnagel@chromium.org, Nov 21 2016

Labels: V1
Libchrome unit testing is not set up, but since we use Chromium's versions of preg_parser and registry_dict now, we don't really need unit tests, anyway.

Still consider adding a fuzzer.

Comment 5 Deleted

Status: Started (was: Assigned)
Labels: -Pri-3 Pri-1
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/479c5684bd7b22ab6305c20ae7266506f39149f5

commit 479c5684bd7b22ab6305c20ae7266506f39149f5
Author: ljusten <ljusten@chromium.org>
Date: Tue Apr 18 08:50:20 2017

Add fuzzer test for preg_parser

The fuzzer does not hook into ReadFile since that reads files and
uses PolicyLoadStatusSample, which in turn creates a histogram entry.
This leads to OOM quicky since the samples accumulate. Thus, this CL
adds a new equivalent ReadData that reads data from memory and writes
status to an PolicyLoadStatus enum.

BUG= 660007 
TEST=Compiled, ran unit tests and fuzzer

Review-Url: https://codereview.chromium.org/2791193005
Cr-Commit-Position: refs/heads/master@{#465179}

[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer.dict
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/empty.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/extension_alternative_spelling.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/registry.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/test1.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/test2.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/test3.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/test4.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/test5.pol
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/chrome/test/data/policy/gpo/fuzzer_corpus/test6.pol
[modify] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/components/policy/core/common/preg_parser.cc
[modify] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/components/policy/core/common/preg_parser.h
[add] https://crrev.com/479c5684bd7b22ab6305c20ae7266506f39149f5/components/policy/core/common/preg_parser_fuzzer.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of Chromad V1 bugs

Sign in to add a comment