New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659985 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Use title casing consistently in contextual menu on long-pressing a link

Project Member Reported by mard...@chromium.org, Oct 27 2016

Issue description

We should use title casing consistently in our contextual menu upon long-pressing a link. 
i.e. it should be "Open in New Incognito Tab" and not "Open in new incognito tab"
 
Status: Untriaged (was: Available)
Correct. Not sure why this never went through triage. 
Labels: -Pri-2 Pri-1
I think this a low hanging fruit that we should fix in our next release.
Cc: jyqu...@chromium.org
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)
When you are fixing title case, there are other occurrences
- "Recent tabs" in toolbar menu
- "Send usage data" in privacy settings (not sure about this one, but "Show Suggestions" on line above is title case)
- "Browsing history" in the "Clear Browsing Data" screen.
All good catches. Thanks, Olivier!
Status: WontFix (was: Assigned)
I've verified that all these strings have already been corrected.
Cc: -jyqu...@chromium.org linds...@chromium.org michaeldo@chromium.org olivierrobin@chromium.org
Owner: ----
Status: Available (was: WontFix)
+ Olivier, Lindsay

Not sure if this is a regression because we added "Read Later" to the context menu upon long-pressing a link but the casing for "Open in New Incognito Tab" is back to "Open in new incognito tab" in Dev and Canary. It should be verified in M57 Beta. 
Labels: M-57
https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=8254185825030391980

"Open in New Incognito Tab" has been translated to 
"Open in new incognito tab" in en-gb

This is the first time in 1 week that en-gb translation breaks the case. Should we add "title case" in desc field?
 
Owner: mard...@chromium.org
Status: Assigned (was: Available)
I think we should let our L10n PgM know about this so that the LQA folks can keep an eye on such things. Not sure whey the translator decided to change the case for en-GB. 

I made a suggestion to fix it in the TC. We should verify in the next M57 Beta build. 
Lindsay: Who is our L10n PgM. I believe it's no longer Ryan, no?
Cc: chiaravanone@chromium.org
I think it is chiaravanone, added to cc
Thanks, Lindsay. 
Chiara: When should my suggestion to this msg be pulled in to our code?
https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=8254185825030391980
....and it would be good to ask the L10n folks why the decided to change the case for en-GB. (see #10)

Thanks!
Cc: cma...@chromium.org manji@chromium.org
Hi Farina, 
Are you the right person to check with for these Chrome for iOS translations? If so, can go/l10npms please be updated?


Chiara is the correct POC. I have just flagged this to her. She will respond shortly

Status: Fixed (was: Assigned)
This is now fixed. Verified in Dev and Canary M58. 

Should be verified for M57.
New localization strings might need to be imported into M57 though. 
Cc: chiaravanone@google.com mlobanov@google.com
fyi I've added Chiara and Maxim's @google accounts so they can view since there was an access problem.

From Chiara,
"
@Maxim: it looks like when translating this TC message ID into enGB (Stronghold project ID: 416068 - Chrome - Automatic request for Chrome), the translators edited the case - this is something we should avoid for consistency (and overall quality) reasons.
"Open in New Incognito Tab" has been translated to 
"Open in new incognito tab" in en-gb

This is the first time in 1 week that en-gb translation breaks the case. 
Based on your experience on enGB, do you think we should add a flag // placeholder "title case" in the description field of this message? or do you think it was a one-time-issue (if so, could you follow up with the linguist who work on that or flag this to the vendor PM)?

Message has been fixed, but the goal is to avoid this in the future and at bigger scale.

Similar flags have been provided on other enGB strings, where capitalization was mishandled for strings targeting iOS devices.
In that specific case, we were considering the idea of asking Eng to add in the TC message description.
 
(1) Tagging for device-specific strings: add the prefix "[case sensitive]" to string message descriptions which are intended for the specific platforms.
ie: "[Chrome - For iOS]" or "[Chrome - For Android]". - maybe this solution could be applied to general capitalization as well
"
Status: Verified (was: Fixed)
Verified in 58.0.3025.0 canary, iPad Pro 10.2

Open in New Incognito Tab
"Recent Tabs" in toolbar menu
"Send Usage Data" in privacy settings 
"Browsing History" in the "Clear Browsing Data" screen.
All are using title casing consistently.
Verified in 57.0.2987.88 dev, iPhone 6S iOS 10.1, iPad mini 9.3.5
Looks good.

Sign in to add a comment