PolicyLoaderWin::LoadGPOPolicy doesn't merge dictionaries properly in some cases |
||||
Issue descriptionA forced GPO that explicitly unsets some policy is not handled properly. If the same policy is set by a non-forced GPO, the forced GPO will not unset the policy. Likewise, a forced GPO with a string list policy that contains less entries than a non-forced GPO will not remove excessive string list entries. Moreover, the way forced GPOs are merged has the same issue. Solution: Always let preg parser do merges, don't use RegistryDict::Merge. preg parser handles special action triggers, e.g. to delete values (policies or string lists). The relevant code is in PolicyLoaderWin::LoadGPOPolicy.
,
Oct 27 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f557ade7166e9b2399c84f6077dc47a4167c5b19 commit f557ade7166e9b2399c84f6077dc47a4167c5b19 Author: ljusten <ljusten@chromium.org> Date: Thu Oct 27 13:15:01 2016 Add comment about wrong policy merging BUG= 659979 Review-Url: https://codereview.chromium.org/2457623003 Cr-Commit-Position: refs/heads/master@{#428009} [modify] https://crrev.com/f557ade7166e9b2399c84f6077dc47a4167c5b19/components/policy/core/common/policy_loader_win.cc
,
Oct 30 2016
,
Jan 19 2017
ljusten@: Could you please close the issue if there is further work to be done here.
,
Jan 19 2017
I assume you mean "NO further work". The CL doesn't address the issue, it just adds a comment to raise awareness. The bug hasn't been addressed.
,
Nov 8 2017
This code is going away, see CL:756707. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ljusten@chromium.org
, Oct 27 2016