New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659965 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove "legacy" stream support from xhr

Project Member Reported by yhirano@chromium.org, Oct 27 2016

Issue description

The legacy stream (i.e., blink::Stream) has been deprecated for years. I would like to remove it from XHR.

SourceBuffer is a Stream customer exposed to JS and its layout tests depend on the legacy stream support on XHR. wolenetz@, are you OK with this removal?
 
What would be necessary to update SourceBuffer::appendStream to current stream definition and implementation? IIUC, the "maxSize" parameter needed something like BYOB readers (see https://github.com/w3c/media-source/issues/14#issuecomment-203953825). Is that still the case, and if so, I don't see BYOB readers implemented in Chrome yet (any ETA?)

To your more immediate question, since appendStream isn't in MSE v1 spec (and in Chrome is legacy-Stream-based and currently behind ExperimentalStream flag), we could drop that from Chrome for now and add it back later if it becomes part of some MSE vNext incubation.
Cc: tyoshino@chromium.org
Thank you! Then I will delete the interface.

BYOB ReadableStream has not been implemented yet. +tyoshino@ as he is working on the feature.

wolenetz: Sorry for not updating you for long time. the BYOB ReadableStream has been standardized and is stable enough for implementation. We prioritized some other works in Q2-3. I think we can move forward in 2017 to add the byte stream construction option to Chrome.

@#2 & #3 SGTM. Thanks
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5862e0528606bfd42e997aeef1b6b82db5f26313

commit 5862e0528606bfd42e997aeef1b6b82db5f26313
Author: yhirano <yhirano@chromium.org>
Date: Tue Nov 08 04:00:35 2016

Remove "legacy" experimental stream support

This CL removes the legacy experimental Stream interface which was replaced
by ReadableStream.

appendStream was removed from the MediaSourceExtension spec v1.
https://github.com/w3c/media-source/issues/14#issuecomment-238363951

BUG= 659965 

Review-Url: https://codereview.chromium.org/2467233002
Cr-Commit-Position: refs/heads/master@{#430513}

[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-set-responsetype.html
[delete] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-append-legacystream.html
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-util.js
[delete] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendstream-quota-exceeded-1mb-buffers.html
[delete] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/third_party/WebKit/LayoutTests/http/tests/media/media-source/stream_memory_tests/mediasource-appendstream-quota-exceeded-default-buffers.html
[delete] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/response-legacystream-abort.html
[delete] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/response-legacystream.html
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/core/streams/Stream.h
[delete] https://crrev.com/03e765142cd8c54c3c082a1924f1c13b4ba18e59/third_party/WebKit/Source/core/streams/Stream.idl
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.idl
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl
[modify] https://crrev.com/5862e0528606bfd42e997aeef1b6b82db5f26313/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Status: Fixed (was: Assigned)
[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?
Labels: M-56

Sign in to add a comment