Move minidump renaming from MinidumpUploadCallable to MinidumpUploadService |
|||
Issue descriptionIn general all of the renaming of minidumps happens in the MinidumpUploadService except for the case where a minidump is uploaded - CrashFileManager.markUploadSuccess - and the cases where a minidump is skipped - CrashFileManager.markUploadSkipped, these are called in MinidumpUploadCallable but could just as well be called in MinidumpUploadService since the upload callable has return values for each of these cases.
,
Nov 5 2016
This doesn't actually block the minidump-upload componentization - we only need to componentize CrashFileManager and MinidumpUploadCallable. (and it's not certain we even want to fix this).
,
Jun 15 2017
Cleaning up some old bugs - I don't think we see this as important enough to fix given that the fix itself will be a bit tricky (in terms of test-changes). |
|||
►
Sign in to add a comment |
|||
Comment 1 by gsennton@chromium.org
, Oct 27 2016