New issue
Advanced search Search tips

Issue 659927 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IpcDesktopEnvironmentTest.CapabilitiesNoTouch failing on Win10 Tests x64

Project Member Reported by foolip@chromium.org, Oct 27 2016 
IpcDesktopEnvironmentTest.CapabilitiesNoTouch (run #1):
[ RUN      ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch
  Actual: "rateLimitResizeRequests touchEvents"
Expected: "rateLimitResizeRequests"
[  FAILED  ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch (2 ms)

IpcDesktopEnvironmentTest.CapabilitiesNoTouch (run #2):
[ RUN      ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch
  Actual: "rateLimitResizeRequests touchEvents"
Expected: "rateLimitResizeRequests"
[  FAILED  ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch (11 ms)

IpcDesktopEnvironmentTest.CapabilitiesNoTouch (run #3):
[ RUN      ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch
  Actual: "rateLimitResizeRequests touchEvents"
Expected: "rateLimitResizeRequests"
[  FAILED  ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch (11 ms)

IpcDesktopEnvironmentTest.CapabilitiesNoTouch (run #4):
[ RUN      ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch
  Actual: "rateLimitResizeRequests touchEvents"
Expected: "rateLimitResizeRequests"
[  FAILED  ] IpcDesktopEnvironmentTest.CapabilitiesNoTouch (11 ms)

Comment 1 by foolip@chromium.org, Oct 27 2016 

Findit points to https://codereview.chromium.org/2456563002 and that looks very plausible, reverting.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0b383452ce174be4f63b6c7e46b8e5180644e2

commit cd0b383452ce174be4f63b6c7e46b8e5180644e2
Author: foolip <foolip@chromium.org>
Date: Thu Oct 27 08:39:44 2016

Revert of Remove supports_touch_events flag from BasicDesktopEnvironment (patchset #2 id:20001 of https://codereview.chromium.org/2456563002/ )

Reason for revert:
IpcDesktopEnvironmentTest.CapabilitiesNoTouch failing on Win10 Tests x64

BUG= 659927 

Original issue's description:
> Remove supports_touch_events flag from BasicDesktopEnvironment
>
> supports_touch_events flag was always enabled on platforms that support
> it, so it's not necessary to put it in BasicDesktopEnvironment.
>
> Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c
> Cr-Commit-Position: refs/heads/master@{#427858}

TBR=zijiehe@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2458513004
Cr-Commit-Position: refs/heads/master@{#427962}

[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/basic_desktop_environment.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/basic_desktop_environment.h
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/desktop_session_proxy.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/desktop_session_proxy.h
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/ipc_desktop_environment.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/ipc_desktop_environment.h
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/ipc_desktop_environment_unittest.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/it2me_desktop_environment.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/it2me_desktop_environment.h
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/me2me_desktop_environment.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/me2me_desktop_environment.h
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/single_window_desktop_environment.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/win/session_desktop_environment.cc
[modify] https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2/remoting/host/win/session_desktop_environment.h

Comment 3 by foolip@chromium.org, Oct 27 2016

Labels: -Sheriff-Chromium
http://build.chromium.org/p/chromium.win/waterfall?builder=Win10%20Tests%20x64 has recovered.

Comment 4 by sergeyu@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)
fixed by revert
►

Sign in to add a comment