New issue
Advanced search Search tips

Issue 659921 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

probe: remove ".*.auto" suffix in probed result

Project Member Reported by akahuang@chromium.org, Oct 27 2016

Issue description

The audio codec driver might add ".*.auto" suffix in the probed result. That confused us because the same component might return the different probed result. Since the suffix is not related to the hardware component, we remove it in the probed result.
 
Summary: probe: remove ".*.auto" suffix in probed result (was: probe: remove ".*.auto" suffix in audio_codec probed result)
Hi Aka, as attached in issue crosbug.com/p/58950#21, the .*.auto is common to all platform device, not just audio codec.

https://cs.corp.google.com/chromeos_public/src/third_party/kernel/v4.4/drivers/base/platform.c?type=cs&q=drivers/base/platform+package:%5Echromeos_public$&l=338


I changed the subject to reflect the fact.
Thanks!

Comment 2 by hungte@chromium.org, Nov 16 2016

Labels: -Pri-3 OS-Chrome Pri-2
Status: Assigned (was: Untriaged)
This should be a quick fix, right
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/48650880e4309727bd861821432c9a710f6a4cc7

commit 48650880e4309727bd861821432c9a710f6a4cc7
Author: Chih-Yu Huang <akahuang@google.com>
Date: Thu Nov 17 09:57:08 2016

gooftool: Remove ".*.auto" suffix in probe result.

When the platform add the device, it would add the .*.auto suffix to the
device name. It causes the probe module gets the different value form the
samecomponent. Therefore we remove the auto-generated suffix.

BUG= chromium:659921 
TEST=py/gooftool/probe_unittest.py

Change-Id: I6ff55f8dfaa5831afd596420a384b0b2b92f9c8c
Reviewed-on: https://chromium-review.googlesource.com/411633
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/48650880e4309727bd861821432c9a710f6a4cc7/py/gooftool/probe_unittest.py
[modify] https://crrev.com/48650880e4309727bd861821432c9a710f6a4cc7/py/gooftool/probe.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016

Labels: merge-merged-factory-gru-8652.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/d8b3c0edb2b611007860cd21806dee12a5d9bc05

commit d8b3c0edb2b611007860cd21806dee12a5d9bc05
Author: Chih-Yu Huang <akahuang@google.com>
Date: Thu Nov 17 09:57:08 2016

CHERRY-PICK: gooftool: Remove ".*.auto" suffix in probe result.

When the platform add the device, it would add the .*.auto suffix to the
device name. It causes the probe module gets the different value form the
samecomponent. Therefore we remove the auto-generated suffix.

BUG= chromium:659921 ,chrome-os-partner:58950
TEST=py/gooftool/probe_unittest.py

Change-Id: Ie3a6b02892deb406609e2934c0891e472cafcb3e
Original-Change-Id: I6ff55f8dfaa5831afd596420a384b0b2b92f9c8c
Reviewed-on: https://chromium-review.googlesource.com/411633
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/412448
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>

[modify] https://crrev.com/d8b3c0edb2b611007860cd21806dee12a5d9bc05/py/gooftool/probe_unittest.py
[modify] https://crrev.com/d8b3c0edb2b611007860cd21806dee12a5d9bc05/py/gooftool/probe.py

Status: Fixed (was: Assigned)
Fixed at comment 3
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 10 2017

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/05d23d254c49299c46a3ae96d9f0933ea55fc6e3

commit 05d23d254c49299c46a3ae96d9f0933ea55fc6e3
Author: Chih-Yu Huang <akahuang@google.com>
Date: Fri Feb 10 05:09:56 2017

gooftool: Remove ".*.auto" suffix in probe result.

When the platform add the device, it would add the .*.auto suffix to the
device name. It causes the probe module gets the different value form the
samecomponent. Therefore we remove the auto-generated suffix.

BUG= chromium:659921 
TEST=py/gooftool/probe_unittest.py

Change-Id: I6ff55f8dfaa5831afd596420a384b0b2b92f9c8c
Reviewed-on: https://chromium-review.googlesource.com/411633
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/440707
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/05d23d254c49299c46a3ae96d9f0933ea55fc6e3/py/gooftool/probe_unittest.py
[modify] https://crrev.com/05d23d254c49299c46a3ae96d9f0933ea55fc6e3/py/gooftool/probe.py

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment