New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659909 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
█ reed@chromium.org
█ rjwrightr@chromium.org
jam@chromium.org
moh...@chromium.org
█ phoglundr@chromium.org
xidac...@chromium.org
ajuma@chromium.org
fmalita@chromium.org
█ dalecurtisr@chromium.org
liyuqian@google.com
█ foolipr@chromium.org
█ hongchanr@chromium.org
█ tyoshinor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Many many tests reported failing in sheriff-o-matic

Project Member Reported by alancutter@chromium.org, Oct 27 2016 
This is a tracking bug for the presence of many many failures being reported in https://sheriff-o-matic.appspot.com/chromium.

Failures:
browser_tests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1)
content_browsertests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1)
interactive_ui_tests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1)
remoting_unittests on Windows-10-10586 failing on chromium.win/Win10 Tests x64
telemetry_perf_unittests on Ubuntu-12.04 failing on chromium.linux/Linux Tests
telemetry_perf_unittests on Windows-7-SP1 failing on 2 builders
webkit_tests failing on 2 builders
webkit_tests failing on chromium.webkit/WebKit Linux Precise
webkit_tests failing on chromium.webkit/WebKit Linux Precise Leak
webkit_tests failing on chromium.webkit/WebKit Linux Trusty
webkit_tests failing on chromium.webkit/WebKit Mac10.10
webkit_tests failing on chromium.webkit/WebKit Mac10.9
webkit_tests failing on chromium.webkit/WebKit Win10
browser_side_navigation_browser_tests on Ubuntu-12.04 failing on chromium.linux/Linux Tests (dbg)(1)
browser_side_navigation_content_browsertests on Ubuntu-12.04 failing on chromium.linux/Linux Tests (dbg)(1)
browser_tests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg)
browser_tests on Mac-10.9 failing on chromium.memory/Mac ASan 64 Tests (1)
browser_tests on Ubuntu-12.04 failing on 2 builders
browser_tests on Ubuntu-12.04 failing on 2 builders
browser_tests on Ubuntu-12.04 failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)
chrome_public_test_apk failing on chromium.linux/Android Tests (dbg)
content_browsertests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg)
content_browsertests on Mac-10.9 failing on chromium.memory/Mac ASan 64 Tests (1)
content_browsertests on Ubuntu-12.04 failing on 2 builders
content_browsertests on Ubuntu-12.04 failing on 2 builders
content_browsertests on Ubuntu-12.04 failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)
interactive_ui_tests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg)
interactive_ui_tests on Mac-10.9 failing on chromium.memory/Mac ASan 64 Tests (1)
interactive_ui_tests on Ubuntu-12.04 failing on 2 builders
interactive_ui_tests on Ubuntu-12.04 failing on 2 builders
interactive_ui_tests on Ubuntu-12.04 failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)
ipc_tests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1)
site_per_process_browser_tests on Ubuntu-12.04 failing on chromium.linux/Linux Tests (dbg)(1)
site_per_process_content_browsertests on Ubuntu-12.04 failing on chromium.linux/Linux Tests (dbg)(1)
sql_unittests on Mac-10.9 failing on chromium.memory/Mac ASan 64 Tests (1)
webkit_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)
webkit_tests failing on chromium.webkit/WebKit Win7

Scouring through the regression ranges they seem to have https://codereview.chromium.org/2458433002 in common.
Have created a revert https://codereview.chromium.org/2447013005/, waiting for the bots to catch up and verify that this patch caused all the failures.


My sheriff rotation is ending now. Could the next Chromium sheriff please close this bug if the failures go away once the builders have caught up with the revert?

Comment 1 by alancutter@chromium.org, Oct 27 2016 

Looks like my revert is not reverting the right thing. The commit that landed is not the last patch in https://codereview.chromium.org/2458433002 so clicking Revert in Rietveld doesn't actually revert the change.

Manually creating a full revert (reverting  the first revert r7fec161fa71c3f0d694398de1d40aa8d6599a7c3 and the breaking commit ra947a329b3030259fbd042458dd6f31b1fe79dcf)...

Comment 2 by alancutter@chromium.org, Oct 27 2016 

I don't think committing a proper revert via Rietveld is feasible with ~8000 files changed. That would explain why it was manually landed in the first place.

My sympathies for the person attempting to make this change, I hope you manage to find a way to do it in pieces.

In the meantime I'm going to continue attempting to revert this manually.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c1292da30259bafbfe65c4a7e3039d0adb565b

commit 54c1292da30259bafbfe65c4a7e3039d0adb565b
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Oct 27 07:40:18 2016

Revert of Turn on Analytic AA in Chrome take 2

This change is a manual revert of the first revert attempt
7fec161fa71c3f0d694398de1d40aa8d6599a7c3 and the breaking change
a947a329b3030259fbd042458dd6f31b1fe79dcf.

Reason for revert:
Broke many tests on many builders, see description in
https://codereview.chromium.org/2447013005

Original issue's description:
> Turn on Analytic AA in Chrome
>
> Update cc_unittests png files to reflect our changes.
>
> We also downgraded some ref tests to pixel tests because
> there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
> circle boundaries. This seems to be reasonable as the test html usually
> has more layers than the ref html. In the future, we may set a
> configurable threshold for ref tests so we don't have to downgrade ref
> tests for this reason.
>
>
> BUG=
>
> patch from issue 2407393003 at patchset 20001 (http://crrev.com/2407393003#ps20001)
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> R=ajuma@chromium.org, fmalita@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a947a329b3030259fbd042458dd6f31b1fe79dcf

TBR=ajuma@google.com,ajuma@chromium.org,jam@google.com,jam@chromium.org,fmalita@chromium.org,reed@google.com,liyuqian@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659909 

Review URL: https://codereview.chromium.org/2457683002 .

Cr-Commit-Position: refs/heads/master@{#427957}

[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/compositing/images/direct-image-clip-path-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/compositing/images/direct-image-dynamic-clip-path-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/compositing/rounded-corners-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-data-uri-svg-image-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-child-layers-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/filters/filter-with-transform-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/filters/nested-filter-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/images/cross-fade-invalidation-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-filter-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-overflow-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-overflow-hidden-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/masking/clip-path-circle-relative-overflow-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/css3/masking/clip-path-ellipse-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/css3/masking/clip-path-restore-expected.txt
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/css3/masking/mask-luminance-svg-expected.txt
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/background-color-image-border-radius-bleed-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/background-leakage-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/background-multi-image-border-radius-bleed-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/background-svg-scaling-expected.png
[rename] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/background-svg-scaling-zoom-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/gradient-background-leakage-2-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/gradient-background-leakage-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/gradient-background-leakage-hidpi-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/svg-as-mask-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/backgrounds/transformed-body-html-background-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/block/basic/fieldset-stretch-to-legend-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-image-rotate-transform-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-left-right-same-bottom-different-color-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-mixed-alpha-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-mixed-alpha2-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-background-constrained-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-complex-inner-double-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-complex-inner-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-different-width-001-double-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-different-width-001-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-groove-01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-groove-02-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-groove-03-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-inset-outset-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-valid-border-clipping-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-02-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-03-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-04-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-wide-border-05-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-box-shadow-01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-box-shadow-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-radius-with-empty-inner-border-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/border-shadow-large-radius-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusArcs01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed02-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed03-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed04-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed05-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDashed06-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted02-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted03-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted04-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted05-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDotted06-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble03-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble04-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble05-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble06-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble07-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble08-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusDouble09-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusGroove01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusGroove02-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusInset01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusMultiColors01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusMultiColors02-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusOutset01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusRidge01-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/borderRadiusSlope-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/empty-border-radius-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-radius-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/mixed-border-styles-radius2-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/borders/table-borders-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/box-shadow/box-shadow-clipped-slices-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/box-shadow/inset-box-shadows-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/box-shadow/shadow-tiling-artifact-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/box-shadow/spread-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/box-shadow/spread-multiple-normal-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-circumference-fill-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-transformclip-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-antiAlias-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-circumference-fill-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/canvas/canvas-zero-length-lineCap-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/css/background-clip-radius-values-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/css/border-solid-single-edge-antialias-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/css/box-shadow-and-border-radius-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/dom/attr_dead_doc-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-iframe-window-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/frames/content-opacity-1-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/frames/content-opacity-2-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/frames/frame-set-rotation-hit-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-rotate-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/frames/frame-set-scaling-skew-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/frames/iframe-text-contents-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/gradients/background-clipped-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/fast/lists/list-marker-before-content-table-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/replaced/border-radius-clip-content-edge-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/table/border-radius-with-image-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/table/giantRowspan-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/table/multiple-percent-height-rows-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/table/table-with-border-radius-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/transforms/rotated-transform-affects-scrolling-1-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/fast/transforms/rotated-transform-affects-scrolling-2-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/http/tests/images/png-partial-load-as-document-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/http/tests/mime/png-image-with-x-png-mime-type-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/background/rounded-clip-fractional-offset-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/paint/clipath/clip-path-with-background-and-box-behind-expected.txt
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/invalidate-paint-for-fixed-pos-inside-iframe-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/nested-iframe-scroll-inner-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/nested-iframe-scroll-outer-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/scroll-fixed-layer-with-transformed-parent-layer-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/scroll-in-transformed-layer-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/scroll-with-transformed-parent-layer-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/fill-opacity-update-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/foreign-object-repaint-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/invalidate-on-child-layout-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-and-object-creation-expected.png
[delete] https://crrev.com/8f2897f7127ee3382505494b716b962df8c8f52a/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-late-marker-creation-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/js-repaint-rect-on-path-with-stroke-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-css-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-child-changes-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-strokeWidth-changes-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/marker-viewBox-changes-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/mask-clip-target-transform-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/object-sizing-no-width-height-change-content-box-size-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/paintorder-filtered-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-moving-svg-and-div-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/repaint-paintorder-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/invalidation/svg/resource-invalidate-on-target-update-expected.png
[modify] https://crrev.com/54c1292da30259bafbfe65c4a7e3039d0adb565b/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.png
[delete] https://crrev.com/8f2897f7127e

Comment 4 by foolip@chromium.org, Oct 27 2016 

Next sheriff here, thanks for the details alancutter@.

Comment 5 by foolip@chromium.org, Oct 27 2016 

Even after that last revert there are widespread layout tests failures due to antialiasing differences, 2076 of them here:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise__dbg_/777/layout-test-results/results.html

Comment 6 by foolip@chromium.org, Oct 27 2016

Status: Fixed (was: Available)
Actually, strike that, that was after the first revert but before the one that fixed it all for other bots. I think this is now under control.

Comment 7 by fmalita@chromium.org, Oct 27 2016 

Unfortunately, I don't think there's a better way to handle large scale rebaselines.

We could try to switch the feature on one platform at a time, but I suspect that's going to cause more rebaseline churn as the platform-specific results diverge.

The other option is to auto-rebaseline - but suppressing of tests even temporarily seems undesirable; plus dealing with existing/partial suppressions in TestExpectations is a nightmare for anything more than a couple dozen tests in my experience.

Which leaves us with this rebaseline process (rebaseline-cl + manual commit), and dealing with the fallout.  I actually thought the number of failures wasn't bad, considering a 2000+ test rebaseline.

I'll try to communicate better next time and minimize the window by running the rebaseline at even odder hours.  But I don't see another feasible option.
►

Sign in to add a comment