Tabs not working/opening
Reported by
vassi...@aretakis.eu,
Oct 27 2016
|
|||||
Issue descriptionDevice name:MediaPad M3 Huawei From "Settings > About Chrome" Application version:Chrome Beta 55.0.2883.28 & Chrome 54.0.2840.6 8 Operating system:Android 6.0.0 BTV-DL09 URLs (if applicable): Steps to reproduce: (1) click on open tabs button (2) nothing happens (3) Expected result: with one or more tabs, you cannot get the list of tabs on chrome Actual result: nothing.
,
Nov 7 2016
Please find attached the debug logging and the video
,
Nov 7 2016
It seems like it works on phone mode instead of Tablet.
,
Nov 15 2016
Thank you for providing more feedback. Adding requester "rsgavara@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15 2016
,
Nov 15 2016
From the video, that looks to be a tablet device running as a phone. twellington@ did work on overriding the context, and maybe has ideas to be diagnose the underlying problem
,
Nov 15 2016
vassilis@aretakis.eu - have you used versions of Chrome before 54? If so, I have two questions: 1. Has it always shown the phone toolbar or did it have a tabstrip (similar to desktop) at some point? 2. Has the tab switcher button always broken or is this issue new to version 54? If the #isTablet() change is to blame, then I expect the answer to #1 is no and the answer to #2 is yes. We don't override the context on pre-N devices, but the #isTablet() calculation does affect which layout manager we use.
,
Nov 15 2016
* #1 wasn't a yes or no question -- I would expect the answer to #1 to be that it's always shown the phone toolbar.
,
Nov 15 2016
* and neither was number #2... I expect that the tab switcher button used to work.
,
Nov 16 2016
Both answers are YES. As the tablet is new to my hands, and experienced these issues from the first moment. With the mentioned versions.
,
Nov 16 2016
Re #10 - thanks! A couple more questions. 3. It would be really helpful to know the display size and device density. This can be achieved in two ways: - run 'adb shell dumpsys display' command - capture a full bugreport per the instructions in comment #1 which will include dumsys info (the logs in comment #2 look like they were just adb logcat, right? When the dumsys is included there should be a log entry for the "DisplayMetrics".) 4. If you install Chrome Dev or Canary (both are at version 56) does it crash on startup? If so, we're working on a fix and this is a related issue.
,
Nov 29 2016
We obtained a MediaPad X2 and were able to reproduce this issue. Huawei has modified the OS to override Android's default resource loading behavior and it's interacting poorly with our DeviceFormFactor#isTablet() check. We have a solution in mind and are targeting Chrome version 56 for the fix.
,
Nov 30 2016
This should be fixed by https://chromium.googlesource.com/chromium/src.git/+/462bbdade8d2adc14423a6d8c08d306feb32fbc8 That patch is in Chrome version 57 and will be merged to version 56.
,
Nov 30 2016
As a work around in the interim, if you change the device's display mode from small to medium, the tab switcher button should work. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rsgav...@chromium.org
, Nov 2 2016