New issue
Advanced search Search tips

Issue 659891 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

memory coordinator: assertion failure in RendererFrameManager::GetMaxNumberOfSavedFrames

Project Member Reported by bashi@chromium.org, Oct 27 2016

Issue description

MemoryCoordinatorImpl::GetCurrentMemoryState() can return MemoryState::SUSPENDED, but clients in browser process don't expect SUSPENDED state. GetCurrentMemoryState() shouldn't return SUSPENDED in the browser process.
 

Comment 1 by bashi@chromium.org, Oct 27 2016

Stacktrace:

#0 0x7fc0185e8a8e base::debug::StackTrace::StackTrace()
#1 0x7fc01860c36b logging::LogMessage::~LogMessage()
#2 0x7fc0162bb05a content::RendererFrameManager::GetMaxNumberOfSavedFrames()
#3 0x7fc0162baca7 content::RendererFrameManager::AddFrame()
#4 0x7fc01642c181 content::DelegatedFrameHost::SwapDelegatedFrame()
#5 0x7fc0162b4dc7 content::RenderWidgetHostViewAura::OnSwapCompositorFrame()
#6 0x7fc0162a8c73 content::RenderWidgetHostImpl::OnSwapCompositorFrame()
#7 0x7fc0162a7198 content::RenderWidgetHostImpl::OnMessageReceived()
#8 0x7fc01629279e content::RenderProcessHostImpl::OnMessageReceived()
#9 0x7fc01712be85 IPC::ChannelProxy::Context::OnDispatchMessage()
#10 0x7fc0185e95c6 base::debug::TaskAnnotator::RunTask()
#11 0x7fc01861811d base::MessageLoop::RunTask()
#12 0x7fc0186184a8 base::MessageLoop::DeferOrRunPendingTask()
#13 0x7fc0186188bb base::MessageLoop::DoWork()
#14 0x7fc01861a7ea base::(anonymous namespace)::WorkSourceDispatch()
#15 0x7fc011c90e04 g_main_context_dispatch
#16 0x7fc011c91048 <unknown>
#17 0x7fc011c910ec g_main_context_iteration
#18 0x7fc01861a546 base::MessagePumpGlib::Run()
#19 0x7fc018617e01 base::MessageLoop::RunHandler()
#20 0x7fc018645c60 base::RunLoop::Run()
#21 0x7fc01967e0ba ChromeBrowserMainParts::MainMessageLoopRun()
#22 0x7fc015fc5099 content::BrowserMainLoop::RunMainMessageLoopParts()
#23 0x7fc015fc83af content::BrowserMainRunnerImpl::Run()
#24 0x7fc015fc095e content::BrowserMain()
#25 0x7fc0166da617 content::RunNamedProcessTypeMain()
#26 0x7fc0166db08b content::ContentMainRunnerImpl::Run()
#27 0x7fc0166d9a00 content::ContentMain()
#28 0x7fc01906152d ChromeMain
#29 0x7fc00f28cf45 __libc_start_main
#30 0x7fc019061409 <unknown>

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0693b4df2baa450f88e4dbefc65a30bafc66e769

commit 0693b4df2baa450f88e4dbefc65a30bafc66e769
Author: bashi <bashi@chromium.org>
Date: Thu Oct 27 09:40:28 2016

GetCurrentMemoryState() shouldn't return SUSPENDED state in browser

At least for now, clients in the browser process don't accept
SUSPENDED state. MemoryCoordinatorImpl::GetCurrentMemoryState()
shouldn't return SUSPENDED state. Use THROTTLED state instead.

BUG= 659891 

Review-Url: https://codereview.chromium.org/2450093006
Cr-Commit-Position: refs/heads/master@{#427980}

[modify] https://crrev.com/0693b4df2baa450f88e4dbefc65a30bafc66e769/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/0693b4df2baa450f88e4dbefc65a30bafc66e769/content/browser/memory/memory_coordinator_impl_unittest.cc

Comment 3 by bashi@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)

Sign in to add a comment