New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659865 link

Starred by 1 user
Status: Duplicate
Merged: issue 632618
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Content settings] improve performance of initial cookie list rendering

Project Member Reported by dschuyler@chromium.org, Oct 27 2016 
In chrome://md-settings/siteSettings/cookies we are concerned that the api is too slow to handle large numbers of cookies.

The current code brings all the cookies from C++ into JS through a tree craw of the cookie data. It also brings in all the cookies even though a limited number of them are visible at any one time.

Comment 1 by dschuyler@chromium.org, Oct 27 2016

Blocking: 614588
Labels: -Pri-3 Pri-2

Comment 2 by dbeam@chromium.org, Oct 27 2016

Blocking: -614588
ultimately nothing perf-related is /dev/ blocking, but it is /beta/ blocking
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68cd6a7fb8998e99a7832617363f3a7f43200fd0

commit 68cd6a7fb8998e99a7832617363f3a7f43200fd0
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Nov 04 21:37:24 2016

[MD settings] get cookie details from site without transfering cookie tree

This CL accelerates the site cookie details page. To fully address the
bug, the main list of cookies (non-details) needs improvement as well.
This CL is a separable step in toward that goal.

BUG= 659865 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2476753002
Cr-Commit-Position: refs/heads/master@{#430021}

[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/resources/settings/site_settings/cookie_info.js
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/ui/webui/cookies_tree_model_util.h
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/68cd6a7fb8998e99a7832617363f3a7f43200fd0/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h

Comment 4 by dbeam@chromium.org, Jan 6 2017

Labels: Hotlist-MD-Settings-Privacy-SiteSettings

Comment 5 by dschuyler@chromium.org, Jan 13 2017

Mergedinto: 632618
Status: Duplicate (was: Assigned)
►

Sign in to add a comment