MacViews: NSFlagsChanged should generate ET_KEY_RELEASED/PRESSED |
||
Issue descriptionChrome Version : 54.0.2840.71 AppKit uses NSFlagsChanged events rather than NSKeyUp/Down events when modifier keys are pressed (Ctrl, Command, Alt, CapsLock, NumLock, etc.). For consistency between platforms we should translate NSFlagsChanged into corresponding KEY_PRESSED/KEY_RELEASED events. WebContents relies on this to deliver consistent events to JS. UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36
,
Nov 3 2016
About handling accelerator-only shortcuts: there seems to be just the 'Alt' key on Windows which focuses the app menu. It follows the Microsoft guideline: https://msdn.microsoft.com/en-us/library/ms971323.aspx#atg_keyboardshortcuts_accessing_menus_and_dialog_boxes And it's implemented in HWNDMessageHandler::OnSysCommand by converting SC_KEYMENU into VK_MENU accelerator: https://cs.chromium.org/chromium/src/ui/views/win/hwnd_message_handler.cc?q=hwndmessagehandle&sq=package:chromium&l=2111
,
Jan 10
Archiving P3s older than 1 year with no owner or component. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 29 2016