Merge WebApkMetaData and WebappInfo
Is this a suggested refactory? I am curious about the motivation, could you explain more or refer to how this issue was brought up?
Yes, this was suggested by Dominick in the code review for https://codereview.chromium.org/2435383002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/560d9b079835e22e14ed118b72840f8b096cda85 commit 560d9b079835e22e14ed118b72840f8b096cda85 Author: pkotwicz <pkotwicz@chromium.org> Date: Wed Nov 02 20:03:41 2016 Merge WebappInfo and WebApkMetaData part 1/2 This CL: - Introduces a new class WebApkInfo which extends WebappInfo - WebApkInfo will contain the properties which are in WebApkMetaData but not in WebappInfo. - WebApkInfo#create() creates a WebApkInfo from an intent. Less intent properties need to be read to create a WebApkInfo object than a WebappInfo object. - Passes WebApkInfo to WebApkUpdateManager BUG= 659845 Review-Url: https://codereview.chromium.org/2457663002 Cr-Commit-Position: refs/heads/master@{#429378} [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java [add] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/java_sources.gni [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java [add] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java [modify] https://crrev.com/560d9b079835e22e14ed118b72840f8b096cda85/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6 commit a4d98ec87f89de45b4e46b5c913dea340e1c2bd6 Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Nov 22 04:49:00 2016 Fix ManifestUpgradeDetectorTest#testManifestEmptyScopeShouldNotUpgrade() https://codereview.chromium.org/2453423002/ changed the scenario being tested. This CL makes #testManifestEmptyScopeShouldNotUpgrade() test the original scenario again. BUG= 659845 Review-Url: https://codereview.chromium.org/2517213002 Cr-Commit-Position: refs/heads/master@{#433790} [modify] https://crrev.com/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java [modify] https://crrev.com/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java [modify] https://crrev.com/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java [modify] https://crrev.com/a4d98ec87f89de45b4e46b5c913dea340e1c2bd6/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edaf18481223e889c230ae9ddbe68d38290982ef commit edaf18481223e889c230ae9ddbe68d38290982ef Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Nov 22 22:52:40 2016 Remove isIconGenerated parameter from WebApkInfo WebAPK icons are never generated. WebAPK creation fails if the icon supplied in the Web Manifest is deficient. BUG= 659845 Review-Url: https://codereview.chromium.org/2513413004 Cr-Commit-Position: refs/heads/master@{#434011} [modify] https://crrev.com/edaf18481223e889c230ae9ddbe68d38290982ef/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java [modify] https://crrev.com/edaf18481223e889c230ae9ddbe68d38290982ef/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java [modify] https://crrev.com/edaf18481223e889c230ae9ddbe68d38290982ef/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb48ebabe16d969057fc583c496729547a1b10d5 commit cb48ebabe16d969057fc583c496729547a1b10d5 Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Nov 28 03:05:25 2016 Merge WebappInfo and WebApkMetaData part 2/2 This CL: - Deletes WebApkMetaData - Adds parameters in WebApkMetaData but not in WebApkInfo to WebApkInfo. - Moves code from WebApkMetaDataUtils to WebApkInfo BUG= 659845 Review-Url: https://codereview.chromium.org/2459023002 Cr-Commit-Position: refs/heads/master@{#434594} [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcher.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java [delete] https://crrev.com/38045133f238c00cc1d2010dda90b7bb47a219cb/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/java_sources.gni [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java [delete] https://crrev.com/38045133f238c00cc1d2010dda90b7bb47a219cb/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java [modify] https://crrev.com/cb48ebabe16d969057fc583c496729547a1b10d5/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/903a9ffa4eadf4fcf87ed1223481010acfbe24a5 commit 903a9ffa4eadf4fcf87ed1223481010acfbe24a5 Author: pkotwicz <pkotwicz@chromium.org> Date: Thu Dec 08 03:05:25 2016 Remove unused WebApkMetaData BUG= 659845 Review-Url: https://codereview.chromium.org/2554143005 Cr-Commit-Position: refs/heads/master@{#437163} [delete] https://crrev.com/b920332c2a50ff61bd1544ef51c6b3563f0bbdd5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaData.java
Comment 1 by hanxi@chromium.org
, Oct 28 2016