New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659835 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-11-17
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Blink doesn't let aria-checked override a native input control's value

Project Member Reported by dmazz...@chromium.org, Oct 26 2016

Issue description

The ARIA spec says that aria-checked should override

 
Labels: Phase3

Comment 2 by dtseng@chromium.org, Nov 17 2016

Labels: -Phase3 framework
NextAction: 2016-11-17
Labels: NewComponent-Accessibility-Blink
Labels: NewComponent-Accessibility
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae91e9c848e802335b5c424e62346b950b49cf31

commit ae91e9c848e802335b5c424e62346b950b49cf31
Author: aleventhal <aleventhal@chromium.org>
Date: Tue Apr 18 00:37:03 2017

AX checked state work

1. Blink should let aria-checked override an input element's native semantics
2. We should support HTML radio/checkbox indeterminate states as mixed,
   even though this is an oversight in the specs
3. We should support aria-checked="mixed" on any kind of radio or checkbox
4. We should support aria-checked on <option> when used for
   role="menuitemcheckbox" or "menuitemradio"

Note: found and fixed at least some additional bugs while working on it:
- The action names for checked/unchecked where reversed
- Android didn't consider role="switch" checkable unless it was already checked

BUG= 659835 
R=dmazzoni
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2694903010
Cr-Commit-Position: refs/heads/master@{#465079}

[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ash/system/ime_menu/ime_list_view.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ash/system/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ash/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/browser/resources/chromeos/chromevox/common/aria_util.js
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/browser/resources/chromeos/chromevox/common/msgs.js
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/test/data/extensions/api_test/automation/sites/attributes.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/chrome/test/data/extensions/api_test/automation/tests/tabs/attributes.js
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/renderer/accessibility/blink_ax_enum_conversion.h
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/aom/aom-checked-expected-blink.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/aom/aom-checked.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/aria/aria-menuitemradio-expected-mac.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/aria/aria-menuitemradio-expected-win.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/aria/aria-posinset-expected-mac.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/aria/aria-switch-expected-android.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/action-verbs-expected-blink.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-checkbox-expected-android.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-checkbox-expected-mac.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-checkbox-expected-win.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-checkbox.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-expected-android.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-expected-blink.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-expected-mac.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-expected-win.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-in-menu-expected-android.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-in-menu-expected-win.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio-in-menu.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/content/test/data/accessibility/html/input-radio.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-expected.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-mixed.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked.html
[add] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/input-mixed.html
[add] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/LayoutTests/accessibility/option-aria-checked.html
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/third_party/WebKit/public/web/WebAXObject.h
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/accessibility/ax_node_position_unittest.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/views/controls/button/toggle_button.cc
[modify] https://crrev.com/ae91e9c848e802335b5c424e62346b950b49cf31/ui/views/controls/menu/menu_item_view.cc

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
Cc: mitsuji@chromium.org yawano@chromium.org dtseng@chromium.org dmazz...@chromium.org
 Issue 638498  has been merged into this issue.

Sign in to add a comment