Set animation name in inspector/animation tests |
|||
Issue descriptionLayoutTests/inspector/animation/animation-timeline.html and LayoutTests/inspector/animation/animation-web-anim-negative-start-time.html contain "FIXME: Set animation name of Web Animation instead; not supported yet" The Animation.id field now exists. Can it be used instead?
,
Oct 28 2016
,
Oct 31 2016
samli: Animation.id is part of the public API, yes.
,
Oct 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddb081c600dc06ec7b0e5604a0400cb11ad6f4e6 commit ddb081c600dc06ec7b0e5604a0400cb11ad6f4e6 Author: Stephen McGruer <smcgruer@chromium.org> Date: Sat Oct 07 03:43:34 2017 Remove FIXMEs in two devtools animation tests As Animation::id is now implemented, Animation.AnimationUI.Color should now be stable for comparing test output against the expected.txt. Bug: 659823 Change-Id: I66ed9b827dd403f2d8c1af80831f6644cb487809 Reviewed-on: https://chromium-review.googlesource.com/706354 Reviewed-by: Samuel Li <samli@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#507275} [modify] https://crrev.com/ddb081c600dc06ec7b0e5604a0400cb11ad6f4e6/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-timeline-expected.txt [modify] https://crrev.com/ddb081c600dc06ec7b0e5604a0400cb11ad6f4e6/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-timeline.html [modify] https://crrev.com/ddb081c600dc06ec7b0e5604a0400cb11ad6f4e6/third_party/WebKit/LayoutTests/http/tests/devtools/animation/animation-web-anim-negative-start-time.html
,
Oct 7 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by samli@chromium.org
, Oct 26 2016