New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659817 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

AppAuth doesn't work on ARC

Project Member Reported by yusukes@chromium.org, Oct 26 2016

Issue description

This is for b/32442730

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250459af2d654e5bf411440f4a034c7e7799b7d6

commit 250459af2d654e5bf411440f4a034c7e7799b7d6
Author: yusukes <yusukes@chromium.org>
Date: Wed Oct 26 23:11:16 2016

Handle navigations with PAGE_TRANSITION_CLIENT_REDIRECT qualifier

to allow the AppAuth web page to work properly with ARC.

BUG= 659817 
TEST=try, run the apk attached to the bug on ARC

Review-Url: https://codereview.chromium.org/2451093004
Cr-Commit-Position: refs/heads/master@{#427866}

[modify] https://crrev.com/250459af2d654e5bf411440f4a034c7e7799b7d6/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

Cc: bhthompson@chromium.org
Labels: M-55 Merge-Request-55
+bhthompson for merge request: this is a very simple change and the impact is high for enterprise SSO
Labels: -Merge-Request-55 Merge-Approved-55
SGTM, looks ARC specific and low risk. 
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ade7b1388fbe7777408bded8378ebb6bda297cd

commit 0ade7b1388fbe7777408bded8378ebb6bda297cd
Author: Yusuke Sato <yusukes@google.com>
Date: Fri Oct 28 03:28:55 2016

Handle navigations with PAGE_TRANSITION_CLIENT_REDIRECT qualifier

to allow the AppAuth web page to work properly with ARC.

BUG= 659817 
TEST=try, run the apk attached to the bug on ARC

(cherry picked from commit 250459af2d654e5bf411440f4a034c7e7799b7d6)

Review URL: https://codereview.chromium.org/2459803002 .

Cr-Commit-Position: refs/branch-heads/2883@{#355}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/0ade7b1388fbe7777408bded8378ebb6bda297cd/chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment