New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659791 link

Starred by 1 user
Status: Duplicate
Merged: issue 659449
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
chanli@chromium.org
lijeffrey@chromium.org
st...@chromium.org
█ robert...@chromium.org
liaoyuke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] http_client should not be a default parameter and should not be set to None

Project Member Reported by lijeffrey@chromium.org, Oct 26 2016 
findit/common/git_repository.py contains the GitRepository class, which allows for the initialization of http_client as None.

This has caused a Findit outage and is difficult to catch in unit tests, so  should be set explicitly and never be set as None to prevent future breakages.

Comment 1 by kateso...@chromium.org, Nov 22 2016

Mergedinto: 659449
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment