New issue
Advanced search Search tips

Issue 659779 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

amd64-generic Trusty (Informational) failed at compile stage

Project Member Reported by x...@chromium.org, Oct 26 2016

Issue description

The informational chrome PFQ amd64-generic Trusty failed at compile stage. Link to the builder: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/amd64-generic%20Trusty%20%28Informational%29

Starting from builder #48189 (https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/amd64-generic%20Trusty%20%28Informational%29/builds/48189)

Log:
FAILED: obj/pdf/pdf/pdfium_engine.o 
/mnt/data/b/build/slave/cache/cipd/goma/gomacc x86_64-cros-linux-gnu-g++ -B/mnt/data/b/build/slave/chrome-tot-chromeos-amd64-generic-trusty/build/.cros_cache/chrome-sdk/tarballs/amd64-generic+8934.0.0+target_toolchain/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/pdf/pdf/pdfium_engine.o.d -DPDFIUM_PRINT_TEXT_WITH_GDI -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_RLZ -DENABLE_SUPERVISED_USERS=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DENABLE_WEBSOCKETS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../v8/include -Igen/v8/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I/mnt/data/b/build/slave/chrome-tot-chromeos-amd64-generic-trusty/build/.cros_cache/chrome-sdk/tarballs/amd64-generic+8934.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nss -I/mnt/data/b/build/slave/chrome-tot-chromeos-amd64-generic-trusty/build/.cros_cache/chrome-sdk/tarballs/amd64-generic+8934.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/nspr -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -m64 -march=x86-64 -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 -gsplit-dwarf --sysroot=../../../.cros_cache/chrome-sdk/tarballs/amd64-generic+8934.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -pipe -pipe -march=x86-64 -msse3 -D__google_stl_debug_vector=1 -c ../../pdf/pdfium/pdfium_engine.cc -o obj/pdf/pdf/pdfium_engine.o
../../pdf/pdfium/pdfium_engine.cc: In member function 'virtual void chrome_pdf::PDFiumEngine::AppendBlankPages(int)':
../../pdf/pdfium/pdfium_engine.cc:2442:22: error: 'MakeUnique' is not a member of 'base'
     pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, true));
                      ^
../../pdf/pdfium/pdfium_engine.cc:2442:49: error: expected primary-expression before '>' token
     pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, true));
                                                 ^
../../pdf/pdfium/pdfium_engine.cc:2442:57: error: left operand of comma operator has no effect [-Werror=unused-value]
     pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, true));
                                                         ^
../../pdf/pdfium/pdfium_engine.cc:2442:60: error: right operand of comma operator has no effect [-Werror=unused-value]
     pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, true));
                                                            ^
../../pdf/pdfium/pdfium_engine.cc: In member function 'void chrome_pdf::PDFiumEngine::LoadPageInfo(bool)':
../../pdf/pdfium/pdfium_engine.cc:2635:24: error: 'MakeUnique' is not a member of 'base'
       pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, false));
                        ^
../../pdf/pdfium/pdfium_engine.cc:2635:51: error: expected primary-expression before '>' token
       pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, false));
                                                   ^
../../pdf/pdfium/pdfium_engine.cc:2635:59: error: left operand of comma operator has no effect [-Werror=unused-value]
       pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, false));
                                                           ^
../../pdf/pdfium/pdfium_engine.cc:2635:62: error: right operand of comma operator has no effect [-Werror=unused-value]
       pages_.push_back(base::MakeUnique<PDFiumPage>(this, i, page_rect, false));
                                                              ^

Suspicious CL: https://codereview.chromium.org/2458493002 
 

Comment 1 by x...@chromium.org, Oct 26 2016

Just found that the suspicous CL has been reverted in https://codereview.chromium.org/2449973004/.

However, the suspicious CL is a revert of a CL that has broke a builder (https://build.chromium.org/p/chromium/builders/Win%20x64/builds/5423/steps/compile/logs/stdio). Revert of the suspicious CL just reland the original CL which will surely break the above builder again.
Status: WontFix (was: Assigned)
I'm working with the sheriffs to reopen the tree. There's no need to file new bugs.
r427785 will go green.

Sign in to add a comment