Issue metadata
Sign in to add a comment
|
[Fullscreen] The slide-in animation is not smooth with CMD-L |
||||||||||||||||||||||
Issue descriptionVersion: Chrome 56.0.2901.0 canary (64-bit) OS: 10.11.6 What steps will reproduce the problem? (1) open a new window (2) go into Fullscreen (3) select "always hide Toolbar in Fullscreen" from the Menu bar (4) press CMD-L (or click into the fake google bar on the NTP) What is the expected output? Smooth slide-in animation of the Toolbar What do you see instead? The slide-in animation is not smooth. Please use labels and text to provide additional information. This is a regression. May be caused by https://codereview.chromium.org/2430403003 ?
,
Oct 27 2016
Unable to reproduce the issue in MacBook Pro Retina 10.11.16 and Mac book air by using chrome reported version #56.0.2901.0. Steps followed to reproduce the issue are as follows: ----------- (1) Opened a new window (2) Pressed Control+Command+F for Fullscreen. (3) Selected "always hide Toolbar in Fullscreen" from the Menu bar. (4) Pressed CMD-L (5) Observed that cursor moved to fake google bar on the NTP and slide-in animation of the toolbar did not behave abnormally. Attaching screen cast for reference mehmet@ - Could you please verify the screen cast and please let us know if anything missed from our side.
,
Oct 27 2016
Hello krajshree@. Thanks for testing it. But that is not what I meant. You have to "deselect" Show always Toolbar in Full Screen and wait until the toolbar disappears. Then you have to press CMD-L or click into the Fake Google search bar. You will notice, that the slide-in animation of the Toolbar will not not smooth in Canary Please find attached two screencasts: Bug_in_Canary and expected_Chrome_Stable
,
Oct 27 2016
,
Nov 8 2016
mehmet@ - Thanks a lot for your clarification. Able to reproduce the issue on Mac OS 10.11.6 using reported version #56.0.2901.0 and latest canary #56.0.2913.3 Bisect Information: ===================== Good build: 54.0.2840.0 Bad Build : 55.0.2841.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/f99c4ade4b10c24a59b7bf34de4d7509e7ca8708..2fdf3d97334819323dc2f42e79fb9d897b069ec4 From the above CL it was not sure about the suspect and to identify the issue was a bit difficult. Hence, from http://omahaproxy.appspot.com/ got the below CL Change Log URL: (From Omahaproxy) https://chromium.googlesource.com/chromium/src/+log/54.0.2840.0..55.0.2841.0?pretty=fuller&n=10000 From the above change log suspecting below change Review-Url: https://codereview.chromium.org/2281033003 dcastagna@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Nov 8 2016
,
Nov 8 2016
No, the regression range is https://chromium.googlesource.com/chromium/src/+log/7a71a1fa240458697111bb6a27aed0804b6b20bd..c8a90c596429c57b9a805d3ec7da56b0ffbcd76c The culprit is https://codereview.chromium.org/2430403003 Assigning back to spqchan@.
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d140c92c5c769bc3e11c642b0de2d69c4a9f3a3 commit 9d140c92c5c769bc3e11c642b0de2d69c4a9f3a3 Author: spqchan <spqchan@chromium.org> Date: Thu Dec 01 18:43:52 2016 [Mac] Fullscreen Toolbar Animation Fix - Fixed the animation so that the toolbar animates in when it's locked by an object BUG= 659752 Review-Url: https://codereview.chromium.org/2542803002 Cr-Commit-Position: refs/heads/master@{#435659} [modify] https://crrev.com/9d140c92c5c769bc3e11c642b0de2d69c4a9f3a3/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm
,
Dec 1 2016
,
Dec 2 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 2 2016
Thanks for the fix, we will verify in latest canary. If all looks good please merge ASAP. FYI: M56 Beta promotion is scheduled on Dec 6 & RC cut on Monday, Dec 5 @ 4.00 PM PST.
,
Dec 5 2016
Verified the fix on Mac 10.12.1 using latest canary #57.0.2939.0 as per the comment #0 and #3. Observed that slide-in animation of the toolbar is smooth as expected. Hence, the fix is working as expected. Attaching the screencast for reference. Adding the verified labels. Thanks...!!
,
Dec 6 2016
M56 Beta promotion is scheduled soon.Please merge your change ASAP so that we could take it for next Release.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adb80b7795001c20ab8fbd84dedfebeeafedb6f5 commit adb80b7795001c20ab8fbd84dedfebeeafedb6f5 Author: spqchan <spqchan@chromium.org> Date: Tue Dec 06 00:07:54 2016 [Mac] Fullscreen Toolbar Animation Fix - Fixed the animation so that the toolbar animates in when it's locked by an object BUG= 659752 Review-Url: https://codereview.chromium.org/2542803002 Cr-Commit-Position: refs/heads/master@{#435659} (cherry picked from commit 9d140c92c5c769bc3e11c642b0de2d69c4a9f3a3) Review URL: https://codereview.chromium.org/2552083002 . Cr-Commit-Position: refs/branch-heads/2924@{#349} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/adb80b7795001c20ab8fbd84dedfebeeafedb6f5/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm
,
Dec 6 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Oct 26 2016