Issue 659748 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Oct 2016
Cc:	skare@chromium.org isherman@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug

Better enforce that the min expected sample of a CustomCountHistogram must be >= 1.

Project Member Reported by se...@chromium.org, Oct 26 2016

Issue description

As Illustrated by this bug:  crbug.com/659739 

It is easy to make the mistake of setting the min expected value to 0. It will only cause problems on the second log, which is why the tests did not detect it.

We should enforce that restriction more.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96ddb18a873f7cfd805abfcfce9ab5ba541857c

commit d96ddb18a873f7cfd805abfcfce9ab5ba541857c
Author: sebsg <sebsg@chromium.org>
Date: Fri Oct 28 21:10:56 2016

Enforce min expected value for CustomCountHistograms on android

BUG= 659748 

Review-Url: https://codereview.chromium.org/2455803002
Cr-Commit-Position: refs/heads/master@{#428490}

[modify] https://crrev.com/d96ddb18a873f7cfd805abfcfce9ab5ba541857c/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
[modify] https://crrev.com/d96ddb18a873f7cfd805abfcfce9ab5ba541857c/base/android/record_histogram.cc
[modify] https://crrev.com/d96ddb18a873f7cfd805abfcfce9ab5ba541857c/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

Comment 2 by se...@chromium.org, Oct 31 2016

Status: Fixed (was: Started)

►

Issue 659748 link

Issue metadata

Better enforce that the min expected sample of a CustomCountHistogram must be >= 1.

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

Comment 1 Deleted

Comment 2 by se...@chromium.org, Oct 31 2016

Comment 2 Deleted

Sign in to add a comment