Issue 659739 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Oct 2016
Components:	UI>Browser>Payments
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	Bug
M-55 Hotlist-Merge-Approved merge-merged-2883

Journey Logger Histograms fail on a second consecutive Payment Request.

Project Member Reported by se...@chromium.org, Oct 26 2016

Issue description

Reason being that the minimum sample is supposed to be set to one.

When the histogram is first created, the 0 min value is silently replaced by a 1.

Then on second payment request the histogram arguments are checked and a DCHECK fails.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fda49ee4f9201fe1190d982fd41a51e5f586e3c1

commit fda49ee4f9201fe1190d982fd41a51e5f586e3c1
Author: sebsg <sebsg@chromium.org>
Date: Thu Oct 27 00:14:41 2016

[Payments] Fix the Payment Request histogram check failure in tests.

BUG= 659739 

Review-Url: https://codereview.chromium.org/2455513004
Cr-Commit-Position: refs/heads/master@{#427887}

[modify] https://crrev.com/fda49ee4f9201fe1190d982fd41a51e5f586e3c1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/fda49ee4f9201fe1190d982fd41a51e5f586e3c1/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/fda49ee4f9201fe1190d982fd41a51e5f586e3c1/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 2 by se...@chromium.org, Oct 27 2016

Labels: -M-56 M-55 Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 27 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved

Your change meets the bar and is auto-approved for M55 (branch: 2883)

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Labels: -merge-approved-55 merge-merged-2883

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b8157730c7d09a5528814ebb91777d4f2dbc914

commit 3b8157730c7d09a5528814ebb91777d4f2dbc914
Author: sebsg <sebsg@chromium.org>
Date: Thu Oct 27 18:30:54 2016

[Payments] Fix the Payment Request histogram check failure in tests.

BUG= 659739 

Review-Url: https://codereview.chromium.org/2455513004
Cr-Commit-Position: refs/heads/master@{#427887}
(cherry picked from commit fda49ee4f9201fe1190d982fd41a51e5f586e3c1)

Review URL: https://codereview.chromium.org/2460603002 .

Cr-Commit-Position: refs/branch-heads/2883@{#343}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/3b8157730c7d09a5528814ebb91777d4f2dbc914/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/3b8157730c7d09a5528814ebb91777d4f2dbc914/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/3b8157730c7d09a5528814ebb91777d4f2dbc914/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 5 by se...@chromium.org, Oct 27 2016

Status: Fixed (was: Started)

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b8157730c7d09a5528814ebb91777d4f2dbc914

commit 3b8157730c7d09a5528814ebb91777d4f2dbc914
Author: sebsg <sebsg@chromium.org>
Date: Thu Oct 27 18:30:54 2016

[Payments] Fix the Payment Request histogram check failure in tests.

BUG= 659739 

Review-Url: https://codereview.chromium.org/2455513004
Cr-Commit-Position: refs/heads/master@{#427887}
(cherry picked from commit fda49ee4f9201fe1190d982fd41a51e5f586e3c1)

Review URL: https://codereview.chromium.org/2460603002 .

Cr-Commit-Position: refs/branch-heads/2883@{#343}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/3b8157730c7d09a5528814ebb91777d4f2dbc914/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/3b8157730c7d09a5528814ebb91777d4f2dbc914/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/3b8157730c7d09a5528814ebb91777d4f2dbc914/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 7 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840

Comment 9 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

►

Issue 659739 link

Issue metadata

Journey Logger Histograms fail on a second consecutive Payment Request.

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

Comment 1 Deleted

Comment 2 by se...@chromium.org, Oct 27 2016

Comment 2 Deleted

Comment 3 by dimu@chromium.org, Oct 27 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

Comment 4 Deleted

Comment 5 by se...@chromium.org, Oct 27 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Comment 6 Deleted

Comment 7 by dimu@google.com, Nov 4 2016

Comment 7 Deleted

Comment 8 by dimu@google.com, Nov 4 2016

Comment 8 Deleted

Comment 9 by lafo...@chromium.org, Jun 27 2017

Comment 9 Deleted

Sign in to add a comment