New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659725 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

https:// is crossed out on a page that is marked dangerous due to malware

Project Member Reported by est...@chromium.org, Oct 26 2016

Issue description

Repro:
* Visit http://parkerly.com/sb-tests/testing_links.html
* Click "bad-subresources"
* Click back-to-safety or back, and the dangerous indicator will then appear, with red cross-out https. The scheme should probably not be crossed out, because there's not actually anything wrong with the connection.
 
Like
Components: -Security>UX Internals>PageSecurityState UI>Browser>Permissions>Indicators
Components: -UI>Browser>Permissions>Indicators UI>Browser>Omnibox>SecurityIndicators
Cc: lgar...@chromium.org est...@chromium.org
 Issue 678336  has been merged into this issue.
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?l=609

   const bool strike = (security_level_ == security_state::DANGEROUS);

We could test if security_info.malicious_content_status != security_state::MALICIOUS_CONTENT_STATUS_NONE, but what happens if a site has both malicious content AND bad HTTPS? Does content_with_cert_errors_status note certificate problems for the main page itself, or only its subdownloads?
This is a plumbing project of questionable value (pedantically, our behavior is "wrong" but making dangerous pages look extra dangerous isn't necessarily bad).

The way to check for a certificate issue is to look at IsCertStatusError(security_info.cert_status). But the problem is that the omnibox code doesn't have a SecurityInfo, it only has the SecurityLevel that it grabbed via GetToolbarModel()->GetSecurityLevel(false). That model gets the answer from the ToolbarModelDelegate, which computes it from the SecurityInfo retrieved by the SecurityStateTabHelper for the current WebContents. ChromeToolbarModelDelegate::GetSecurityLevel().

Comment 7 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 8 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment