New issue
Advanced search Search tips

Issue 659723 link

Starred by 1 user
Status: Fixed
Owner:
petewil@chromium.org
Closed: Nov 2016
Cc:
dougarnett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tune web page background fetching

Project Member Reported by petewil@chromium.org, Oct 26 2016 
While debugging, I discovered that we were not counting timeout attempts as completed attempts.

Since most users in India and Indonesia probably have poor 2G all the time, I've removed the NQE check for immediate downloading so that they can still get immediate downloads.

I've increased the timeouts for OnDomContentLoaded and OnLoad to allow for enough processing time on slow connections.  In the future, we may tune this by connection type.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11aeb394f106f8ee8dccd0b01d03d107ae535c44

commit 11aeb394f106f8ee8dccd0b01d03d107ae535c44
Author: petewil <petewil@chromium.org>
Date: Fri Oct 28 21:57:43 2016

Tune web page background fetching

1. Treat timeout attempts as a completed attempt, not a started attempt.

2. Disable NQE check before doing immediate loading

3. Increase timing on OnDomContentLoaded to allow for poor 2G networks.

BUG= 659723 

Review-Url: https://codereview.chromium.org/2450293002
Cr-Commit-Position: refs/heads/master@{#428506}

[modify] https://crrev.com/11aeb394f106f8ee8dccd0b01d03d107ae535c44/chrome/browser/android/offline_pages/prerendering_loader.cc
[modify] https://crrev.com/11aeb394f106f8ee8dccd0b01d03d107ae535c44/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/11aeb394f106f8ee8dccd0b01d03d107ae535c44/components/offline_pages/background/request_coordinator_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29949425c4db0345ee92b384dd403d325df6d63a

commit 29949425c4db0345ee92b384dd403d325df6d63a
Author: dougarnett <dougarnett@chromium.org>
Date: Thu Nov 03 00:17:31 2016

[Offline Pages] Call snapshot controller when OnDomContentLoaded received

Looks like we missed putting back PrerenderLoader's call to snapshot controller
in patch 2450293002

BUG= 659723 

Review-Url: https://codereview.chromium.org/2473443004
Cr-Commit-Position: refs/heads/master@{#429469}

[modify] https://crrev.com/29949425c4db0345ee92b384dd403d325df6d63a/chrome/browser/android/offline_pages/prerendering_loader.cc

Comment 4 by petewil@chromium.org, Nov 30 2016

Status: Fixed (was: Started)
We've tuned as much as we think we should for now, we may revisit this later when we have more data.
►

Sign in to add a comment