Issue metadata
Sign in to add a comment
|
"Dangerous" indicator persists after "back to safety" |
||||||||||||||||||||||||
Issue descriptionVersion: 54.0.2840.71 (stable) linux, and 56.0.2897.0 (dev) Repro: * visit http://testsafebrowsing.appspot.com * Click first link. * Click "back to safety" or hit back * red triangle persists, even though nothing on the current page is flagged. Counter-repro on HTTPS: * visit httpS://testsafebrowsing.appspot.com and do the same as above * Green lock correctly appears
,
Oct 26 2016
Re: #1, verbose strings aren't launched yet, they're on for 50% of canary/dev right now. (And they're off by default as of https://codereview.chromium.org/2435493003/) So I think this is indeed WAI, unless we want to change what's intended. The warning sticks with the hostname for the lifetime of the WebContents.
,
Oct 26 2016
Hmm, this means if you're on a site that at some point shows an ad from a blacklisted site, and you click back on the warning to the "good" part of the site, you'll still see a dangerous indicator. That does seems misleading.
,
Oct 26 2016
,
Oct 27 2016
Oh, actually, I got a bit confused here. Issue 651055 is intended: once you *click through* an interstitial, you get a dangerous icon on that hostname for the lifetime of the WebContents. If you don't proceed through the interstitial, though, we should probably not continue to show the dangerous icon for the hostname.
,
Oct 27 2016
,
Oct 27 2016
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ca09ca22c714b67a7d2be4070686065f47fd9d7 commit 1ca09ca22c714b67a7d2be4070686065f47fd9d7 Author: estark <estark@chromium.org> Date: Tue Nov 01 04:04:12 2016 Remove Dangerous indicator after going back from interstitial While showing a Safe Browsing interstitial, the top-level hostname for the WebContents gets added to a "pending" whitelist set. Previously, we were never removing URLs from that set, meaning that if you went Back from an interstitial to a URL on the same hostname, the Dangerous indicator persisted. This CL fixes this bug by removing pending whitelist URLs when an interstitial is dismissed with the Don't Proceed option. BUG= 659709 TEST=Visit http://testsafebrowsing.appspot.com, click first link. Observe that the icon in the omnibox is a red triangle. Click "Back to safety". Observe that the icon in the omnibox is an (i), not a red triangle. TEST=Added browser test Review-Url: https://codereview.chromium.org/2451623005 Cr-Commit-Position: refs/heads/master@{#428932} [modify] https://crrev.com/1ca09ca22c714b67a7d2be4070686065f47fd9d7/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc [modify] https://crrev.com/1ca09ca22c714b67a7d2be4070686065f47fd9d7/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/1ca09ca22c714b67a7d2be4070686065f47fd9d7/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc [modify] https://crrev.com/1ca09ca22c714b67a7d2be4070686065f47fd9d7/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/1ca09ca22c714b67a7d2be4070686065f47fd9d7/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/1ca09ca22c714b67a7d2be4070686065f47fd9d7/chrome/browser/safe_browsing/ui_manager_unittest.cc
,
Nov 1 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Oct 26 2016