Chromium crashed when in DON flow |
|||
Issue description
repo step:
1. navigate to a webvr content
2. click present button
3. insert phone into a Daydream headset
Sometimes, Chromium crashed on this check:
void VrShellUIMessageHandler::OnJavascriptAllowed() {
CHECK(vr_shell_);
...
}
Note: this can only be reproduced after https://bugs.chromium.org/p/chromium/issues/detail?id=656723 fixed.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db320fb20abdc36642a1148fa24224a7fabaa620 commit db320fb20abdc36642a1148fa24224a7fabaa620 Author: mthiesse <mthiesse@chromium.org> Date: Thu Oct 27 21:00:08 2016 Exit VR Shell on pause (And fix a bunch of minor bugs). Also fixed a possible bug where we'd incorrectly reset rotation. Fixed a bug where the control container was hidden on resume, and pages without scrolling couldn't bring it back. Fixed a crash exiting VR shortly after entering. BUG= 653182 , 659707 Review-Url: https://codereview.chromium.org/2453943002 Cr-Commit-Position: refs/heads/master@{#428132} [modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/browser/android/vr_shell/vr_shell_delegate.cc [modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/browser/android/vr_shell/vr_shell_delegate.h [modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc
,
Oct 28 2016
,
Dec 5 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bshe@chromium.org
, Oct 27 2016