New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659672 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , All
Pri: 1
Type: Bug

Blocking:
issue 655233



Sign in to add a comment

Implement step 5 for watchAvailability algorithm

Project Member Reported by avayvod@chromium.org, Oct 26 2016

Issue description

See https://w3c.github.io/remote-playback/#getting-the-remote-playback-devices-availability-information.

Need plumbing similar to that of the Presentation API to expose if background discovery is available on the device to Blink.
 
Blocking: 655233
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2707b633861011503944b886e36e3708e39d2593

commit 2707b633861011503944b886e36e3708e39d2593
Author: avayvod <avayvod@chromium.org>
Date: Tue Nov 29 22:27:59 2016

[RemotePlayback] No monitoring on low-end devices

BUG= 659672 
TEST=layout test with extra plumbing through Internals

Review-Url: https://codereview.chromium.org/2475293003
Cr-Commit-Position: refs/heads/master@{#435095}

[add] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-throws-low-end-device.html
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/platform/MemoryCoordinator.h
[modify] https://crrev.com/2707b633861011503944b886e36e3708e39d2593/third_party/WebKit/Source/platform/exported/Platform.cpp

Labels: Merge-Request-56 OS-Android
Status: Fixed (was: Assigned)

Comment 4 by dimu@chromium.org, Nov 30 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6c49111ef6106c90b25b4db662e7d71e00b7ee3

commit d6c49111ef6106c90b25b4db662e7d71e00b7ee3
Author: Anton Vayvod <avayvod@google.com>
Date: Wed Nov 30 17:23:06 2016

[Blink Heap] Move isLowEndDevice to Memory Coordinator, attempt #3

A preparation for https://codereview.chromium.org/2475293003 to be able to
override this from tests.

Had to go with a static method approach. Seems like hanging it off the heap allocated object breaks blink_heap_unittests on Mac and Windows
(see https://codereview.chromium.org/2503433003 and https://codereview.chromium.org/2510353005).

BUG= 659672 
TEST=Run the blink_heap_unittests locally (on Linux).

Review-Url: https://codereview.chromium.org/2518273003
Cr-Commit-Position: refs/heads/master@{#434027}
(cherry picked from commit caab7202c6ecbbaf5caa71be51e7c1d061606f35)

Review URL: https://codereview.chromium.org/2542683002 .

Cr-Commit-Position: refs/branch-heads/2924@{#191}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/d6c49111ef6106c90b25b4db662e7d71e00b7ee3/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/d6c49111ef6106c90b25b4db662e7d71e00b7ee3/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/d6c49111ef6106c90b25b4db662e7d71e00b7ee3/third_party/WebKit/Source/platform/MemoryCoordinator.h
[modify] https://crrev.com/d6c49111ef6106c90b25b4db662e7d71e00b7ee3/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/d6c49111ef6106c90b25b4db662e7d71e00b7ee3/third_party/WebKit/Source/platform/heap/Heap.h
[modify] https://crrev.com/d6c49111ef6106c90b25b4db662e7d71e00b7ee3/third_party/WebKit/Source/platform/heap/HeapPage.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5243d6caa28aae2bf2f9173250ddaafe0c058203

commit 5243d6caa28aae2bf2f9173250ddaafe0c058203
Author: Anton Vayvod <avayvod@google.com>
Date: Wed Nov 30 18:29:00 2016

[RemotePlayback] No monitoring on low-end devices

BUG= 659672 
TEST=layout test with extra plumbing through Internals

Review-Url: https://codereview.chromium.org/2475293003
Cr-Commit-Position: refs/heads/master@{#435095}
(cherry picked from commit 2707b633861011503944b886e36e3708e39d2593)

Review URL: https://codereview.chromium.org/2541873003 .

Cr-Commit-Position: refs/branch-heads/2924@{#197}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[add] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-throws-low-end-device.html
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/platform/MemoryCoordinator.h
[modify] https://crrev.com/5243d6caa28aae2bf2f9173250ddaafe0c058203/third_party/WebKit/Source/platform/exported/Platform.cpp

Sign in to add a comment