SSL.MarkHttpAs histogram doesn't get data, wrong histogram name in code |
||||
Issue descriptionhistograms.xml has a histogram called SSL.MarkHttpAs, but in the code (in ChromeSecurityStateModelClient), the recorded histogram just uses "MarkHttpAs" as the name. So we're not getting any data for SSL.MarkHttpAs. We should fix the code and add a unit test.
,
Oct 26 2016
(Though, a test might not have caught this particular problem, because the test probably would have used the same histogram name in the code.)
,
Oct 26 2016
,
Oct 26 2016
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc254a3aee4b483f4bbc0acaa37dbe71648c06ef commit fc254a3aee4b483f4bbc0acaa37dbe71648c06ef Author: elawrence <elawrence@chromium.org> Date: Wed Oct 26 21:15:45 2016 Use correct histogram name in security_state_model Histograms.xml uses "SSL.MarkHttpAsStatus" but the code omitted the "SSL." prefix. This CL fixes the code to match the XML. BUG= 659667 Review-Url: https://codereview.chromium.org/2453063002 Cr-Commit-Position: refs/heads/master@{#427794} [modify] https://crrev.com/fc254a3aee4b483f4bbc0acaa37dbe71648c06ef/components/security_state/security_state_model.cc [modify] https://crrev.com/fc254a3aee4b483f4bbc0acaa37dbe71648c06ef/components/security_state/security_state_model_unittest.cc
,
Oct 26 2016
Thanks Eric!
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
||||
►
Sign in to add a comment |
||||
Comment 1 by est...@chromium.org
, Oct 26 2016