New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 659662 link

Starred by 11 users
Status: Fixed
Owner:
█ irisu@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
eseckler@chromium.org
skyos...@chromium.org
altimin@chromium.org
█ alexclarke@chromium.org
█ sureshkumari@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 696350



Sign in to add a comment

Allow handling certificate errors via DevTools

Project Member Reported by eseckler@chromium.org, Oct 26 2016 
For headless, we can't show a UI warning for bad certificates as chrome does. Instead, we should investigate exposing certificate errors as events through DevTools and controlling what action to take through a DevTools command.

FYI, currently such errors are handled in SSLManager::OnCertErrorInternal, which delegates to ContentBrowserClient::AllowCertificateError.

Comment 1 by skyos...@chromium.org, Dec 5 2016

Labels: HeadlessUpForGrabs

Comment 2 by eseckler@chromium.org, Jan 19 2017

Labels: -HeadlessUpForGrabs
Owner: irisu@chromium.org
Status: Started (was: Available)

Comment 4 by sleevi@google.com, Feb 27 2017

Components: Internals>Network>Certificate UI>Browser>Interstitials
Adding Certificate and Interstitials owners, since this would give DevTools the ability to handle/bypass interstitials.

Comment 5 by eseckler@chromium.org, Feb 27 2017

Blocking: 696350

Comment 6 by eseckler@chromium.org, Mar 2 2017

Cc: sureshkumari@chromium.org eseckler@chromium.org
 Issue 697721  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8452ddd64771d3573cd7083f3e6e263cf67fbe1b

commit 8452ddd64771d3573cd7083f3e6e263cf67fbe1b
Author: irisu <irisu@chromium.org>
Date: Wed Mar 22 07:46:14 2017

Add certificate error handling to devtools.

This is necessary as headless chrome cannot show a UI warning for SSL
certificate errors. Instead, we can expose the errors as DevTools events
and control the action to take through a DevTools command.

BUG= 659662 

Review-Url: https://codereview.chromium.org/2639203003
Cr-Commit-Position: refs/heads/master@{#458673}

[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/browser/devtools/protocol/security_handler.cc
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/browser/devtools/protocol/security_handler.h
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/browser/ssl/ssl_manager.cc
[add] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/test/data/devtools/image.html
[add] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/content/test/data/devtools/test.jpg
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/8452ddd64771d3573cd7083f3e6e263cf67fbe1b/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Comment 8 by irisu@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Comment 9 by rsleevi@chromium.org, Mar 23 2017

Labels: M-59
►

Sign in to add a comment