[Web Payments] The validation logic that verifies that a payment request, sent from the vendor web page, is valid is under WebKit. This makes it inaccessible to iOS. This issue represents a request to move it under components/.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be5499627776990fbf5ed4af9538f6aff414eaac commit be5499627776990fbf5ed4af9538f6aff414eaac Author: krb <krb@chromium.org> Date: Thu Nov 03 20:16:54 2016 [Web Payments] Common Payments validation Provides Payment Validation JNI interface to Java(Android). The interface is also available to Views, but Blink still uses existing validation routines due to type conflicts (which we hope to resolve.) This is a follow up to 2373103002, which solely moved the Mojo file from Blink to components/ BUG= 659644 Review-Url: https://codereview.chromium.org/2373103002 Cr-Commit-Position: refs/heads/master@{#429685} [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentValidator.java [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/chrome/android/java_sources.gni [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/chrome/browser/BUILD.gn [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/chrome/browser/android/chrome_jni_registrar.cc [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/BUILD.gn [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/BUILD.gn [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/DEPS [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/android/BUILD.gn [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/android/DEPS [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/android/payments_jni_registrar.cc [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/android/payments_jni_registrar.h [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/payment_details_validation.cc [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/payment_details_validation.h [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/payment_request.mojom [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/payments_validators.cc [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/payments_validators.h [add] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/components/payments/payments_validators_test.cc [modify] https://crrev.com/be5499627776990fbf5ed4af9538f6aff414eaac/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 commit 3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 Author: krb <krb@chromium.org> Date: Wed Nov 09 18:45:09 2016 [Web Payments] Mojom namespace blink -> payments When we migrated payment_request.mojom from Blink to components/ we left the namespace in place to minimize changes and facilitate the move. This CL simply changes the namespace that the payment request stuff resides in. Lots of files changed, little depth. BUG= 659644 Review-Url: https://codereview.chromium.org/2477883002 Cr-Commit-Position: refs/heads/master@{#430990} [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/android/payments_jni_registrar.cc [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/payment_details_validation.cc [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/payment_details_validation.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/payment_request.mojom [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/payments_validators.cc [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/payments_validators.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/components/payments/payments_validators_test.cc [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/AbortTest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/CompleteTest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentAddressTest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90916b06da350459d3cc60a8d89ad2fe2b56c063 commit 90916b06da350459d3cc60a8d89ad2fe2b56c063 Author: dpranke <dpranke@chromium.org> Date: Wed Nov 09 19:48:39 2016 Revert of [Web Payments] Mojom namespace blink -> payments (patchset #5 id:80001 of https://codereview.chromium.org/2477883002/ ) Reason for revert: Looks like this broke some tests on at least Android: https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/6152 so I'm reverting this. Sorry! Original issue's description: > [Web Payments] Mojom namespace blink -> payments > > When we migrated payment_request.mojom from Blink to components/ > we left the namespace in place to minimize changes and facilitate > the move. This CL simply changes the namespace that the payment > request stuff resides in. Lots of files changed, little depth. > > BUG= 659644 > > Committed: https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 > Cr-Commit-Position: refs/heads/master@{#430990} TBR=mkwst@chromium.org,rouslan@chromium.org,krb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 659644 Review-Url: https://codereview.chromium.org/2489943003 Cr-Commit-Position: refs/heads/master@{#431014} [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/android/payments_jni_registrar.cc [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/payment_details_validation.cc [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/payment_details_validation.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/payment_request.mojom [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/payments_validators.cc [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/payments_validators.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/components/payments/payments_validators_test.cc [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/AbortTest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/CompleteTest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentAddressTest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b commit fccaa20f7991d3e76810d8c8a9c1516625cf4c2b Author: krb <krb@chromium.org> Date: Thu Nov 10 19:45:29 2016 [Web Payments] Mojom namespace blink -> payments When we migrated payment_request.mojom from Blink to components/ we left the namespace in place to minimize changes and facilitate the move. This CL simply changes the namespace that the payment request stuff resides in. Lots of files changed, little depth. BUG= 659644 Committed: https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 Review-Url: https://codereview.chromium.org/2477883002 Cr-Original-Commit-Position: refs/heads/master@{#430990} Cr-Commit-Position: refs/heads/master@{#431320} [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/android/payments_jni_registrar.cc [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/payment_details_validation.cc [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/payment_details_validation.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/payment_request.mojom [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/payments_validators.cc [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/payments_validators.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/components/payments/payments_validators_test.cc [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/AbortTest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/CompleteTest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentAddress.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentAddress.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentAddressTest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentRequest.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentResponse.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentsValidators.h [modify] https://crrev.com/fccaa20f7991d3e76810d8c8a9c1516625cf4c2b/third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp
Comment 1 by rouslan@chromium.org
, Oct 26 2016