Preload links without type attribute gaining higher priority
Reported by
rafala...@gmail.com,
Oct 26 2016
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36 Steps to reproduce the problem: 1. Create some preload links but one of them without type attribute 2. Open timeline panel on chrome developer tools 3. You will see that the preload without type attribute will start load before others Or open this link: http://output.jsbin.com/yopoha What is the expected behavior? All preloads start to load in the same sequence they appear on markup What went wrong? The preload links with type attribute will start load after css and js Did this work before? Yes I know that it were working on 51.* Does this work in other browsers? No Only chrome and opera supports preload by now. I did not test on Opera. Chrome version: 53.0.2785.143 Channel: stable OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0
,
Oct 26 2016
,
Oct 27 2016
,
Nov 18 2016
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b86dfe66171ac6b9641ea596c74369e515de917 commit 5b86dfe66171ac6b9641ea596c74369e515de917 Author: yoav <yoav@yoav.ws> Date: Wed Jan 11 13:12:18 2017 Fix HTMLPreloadScanner handling of type in link preload. Handling of the `type` attribute in `<link rel=preload>` was not properly added, which meant preloads that included a valid type were dismissed due to rel=stylesheet related logic. This CL adds proper handling for the `type` attribute in `<link rel=preload>` for fonts, images and styles. BUG= 659640 Review-Url: https://codereview.chromium.org/2620993002 Cr-Commit-Position: refs/heads/master@{#442887} [modify] https://crrev.com/5b86dfe66171ac6b9641ea596c74369e515de917/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp [modify] https://crrev.com/5b86dfe66171ac6b9641ea596c74369e515de917/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp [modify] https://crrev.com/5b86dfe66171ac6b9641ea596c74369e515de917/third_party/WebKit/Source/core/loader/LinkLoader.cpp [modify] https://crrev.com/5b86dfe66171ac6b9641ea596c74369e515de917/third_party/WebKit/Source/core/loader/LinkLoader.h
,
Jan 11 2017
Apologies it took so long. Fixed now (after hitting the same issue on my own blog...)
,
Jan 11 2017
That's great. Thank you guys. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by y...@yoav.ws
, Oct 26 2016