Long URLs make the MD downloads page load very slowly |
|||||
Issue descriptionVersion: Chrome 55 What steps will reproduce the problem? (1) Visit: https://jsfiddle.net/5rfsn7mo/ (2) Download the 1MB data url link. (3) Open MD downloads page. What is the expected output? Downloads page should load quickly. What do you see instead? Downloads page takes ~1 minute to load. Please use labels and text to provide additional information. Tracing shows that all the time is being spent in layout. The 1MB string for the URL is too much for layout to handle efficiently even though it's abbreviated. The downloads page should pass URL text through its own truncation filter to prevent this excessive load time. Though a 1MB data URL seems unlikely I came across this without trying. One of the images I had saved previously turned out to be a 2MB data URL PNG.
,
Oct 28 2016
,
Oct 28 2016
totalll bummerrr
,
Oct 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/407a59a4369bbd1915d50d74dc18a12e3e102539 commit 407a59a4369bbd1915d50d74dc18a12e3e102539 Author: dbeam <dbeam@chromium.org> Date: Sat Oct 29 01:54:33 2016 MD Downloads: reduce the size of the ellided, displayed download URL R=alancutter@chromium.org BUG= 659636 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2455393004 Cr-Commit-Position: refs/heads/master@{#428587} [modify] https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/407a59a4369bbd1915d50d74dc18a12e3e102539/chrome/test/data/webui/md_downloads/layout_tests.js
,
Oct 30 2016
,
Nov 16 2016
,
Apr 4 2017
FYI, we are observing the same behavior in MD Settings, when the logged in user's name is too long. Suspecting the same rot cause. Will file a separate bug for it and we can talk there about the appropriate fix. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rsch...@chromium.org
, Oct 27 2016