Reloading ToS looses selected language. |
|||
Issue descriptionVersion: ToT OS: ChromeOS How to reproduce: 0) Make sure ARC is disabled, and network is connected. 1) Open chrome://settings, and enable ARC. 2) Wait for ToS page. 3) Scroll down to the ToS, and find language selection. 3.5) Disconnect network (just to let loading fail). 4) Select another language. 5) Make sure the operation is failed. 5.5) Restore the network. 6) click RETRY on the page. Expected behavior: - ToS page of the selected lang is loaded. Actual behavior: - En page is loaded. Sometimes, the loading is triggered twice so the loading progress bar is flickering. Note: disconnecting/reconnecting network is not essential. Any fail on language selection triggers this bug.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03d3d5a0d122ab8ab1289cbca2af84377c924415 commit 03d3d5a0d122ab8ab1289cbca2af84377c924415 Author: hidehiko <hidehiko@chromium.org> Date: Fri Nov 04 05:35:55 2016 Fix losing selected language on ToS page reloading. The reloading implemented by setting url to the ToS page directly. However, it has some redirection and user may select another language. Setting the page again triggers to redirection to the default page. Also, it sometimes triggers another redirection which causes flickering of the page. Fix the problems by reload(). BUG= 659633 TEST=Ran on device. Ran trybots. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2449393002 Cr-Commit-Position: refs/heads/master@{#429796} [modify] https://crrev.com/03d3d5a0d122ab8ab1289cbca2af84377c924415/chrome/browser/resources/chromeos/arc_support/background.js
,
Nov 4 2016
,
Nov 22 2016
Verified on ChromeOS 9011.0.0, 57.0.2926.0 |
|||
►
Sign in to add a comment |
|||
Comment 1 by khmel@chromium.org
, Oct 26 2016