New issue
Advanced search Search tips

Issue 659607 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Mobile-friendly view is wrongly triggered on hackaday.com

Project Member Reported by skyos...@chromium.org, Oct 26 2016

Issue description

Version: 56.0.2900.3
OS: Android

What steps will reproduce the problem?
(1) Navigate to hackaday.com
(2) Click the "Make this page mobile-friendly" popup.

What is the expected output?
Something that includes the articles from the page.

What do you see instead?
Mobile friendly view is mostly blank.


 
hackaday-before.png
1.2 MB View Download
hackaday-after.png
110 KB View Download

Comment 1 by wychen@chromium.org, Oct 27 2016

Cc: mdjones@chromium.org k...@chromium.org
Owner: wychen@chromium.org
Looks like a false positive in the triggering logic. Just to be sure, did you change the triggering heuristics in flags? If your chrome://flags#reader-mode-heuristics is "Appears to be an article", then it's using the Adaboost model, which should be the default.

I tried to reproduce it locally, but the classification result is NOT to show the prompt, which is correct.

adaboost_classification = {
   "blacklisted": 0,
   "derived_features": [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1.0, 1.0, 0.0, 0.0, 0.0, 1.0, 3.0, 167.0, 686.0, 0.2434402332361516, 20.46948949045872, 23.643180835073778, 559.0 ],
   "distillable": 0,
   "features": {
      "anchorCount": 167,
      "elementCount": 686,
      "formCount": 3,
      "isMobileFriendly": 0,
      "mozScore": 20.46948949045872,
      "mozScoreAllLinear": 559.0,
      "mozScoreAllSqrt": 23.643180835073778,
      "openGraph": 0,
      "passwordInputCount": 0,
      "textInputCount": 2
   },
   "long_page": 0,
   "long_score": -0.6895042893142644,
   "score": -0.13034317356566089
}

Comment 2 by wychen@chromium.org, Oct 27 2016

Sorry, I forgot to turn JS back on from last debugging session.

With JS on, the classification matches the symptom.

adaboost_classification = {
   "blacklisted": 0,
   "derived_features": [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 1.0, 1.0, 0.0, 0.0, 0.0, 1.0, 3.0, 177.0, 731.0, 0.2421340629274966, 128.03578826196147, 180.08871649031806, 3560.0 ],
   "distillable": 1,
   "features": {
      "anchorCount": 177,
      "elementCount": 731,
      "formCount": 3,
      "isMobileFriendly": 0,
      "mozScore": 128.03578826196147,
      "mozScoreAllLinear": 3560.0,
      "mozScoreAllSqrt": 180.08871649031806,
      "openGraph": 0,
      "passwordInputCount": 0,
      "textInputCount": 2
   },
   "long_page": 1,
   "long_score": 0.18815486307294982,
   "score": 0.21965375368971324
}

Comment 3 by wychen@chromium.org, Oct 27 2016

The mozScore* features are too high, due to the swipeable article snippets in div.slick-slider. One possible fix is to disregard texts inside <a> when processing <p>, but this can be too costly to compute.

Comment 4 by wychen@chromium.org, Oct 27 2016

Status: Available (was: Untriaged)
Summary: Mobile-friendly view is wrongly triggered on hackaday.com (was: Mobile-friendly view of hackaday.com is mostly blank)


Thanks for looking into this. FWIW my chrome://flags#reader-mode-heuristics is "Default" and I get the reader mode prompt every time.
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by k...@chromium.org, Feb 15 2018

Cc: -k...@chromium.org

Comment 8 by bauerb@chromium.org, Feb 19 2018

Status: Assigned (was: Untriaged)
Clank Frontend triaging: Issues with an owner are by definition assigned.

If you can't work on this, please unassign yourself as owner and mark back as available or untriaged. Thanks!

Sign in to add a comment