Issue metadata
Sign in to add a comment
|
Printing Issues over Terminal Services with Chrome 54
Reported by
chrisnev...@googlemail.com,
Oct 26 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 54.0.2840.71 m URLs (if applicable) : https://jsfiddle.net/2dsu99ru/ Other browsers tested: IE: PASS What steps will reproduce the problem? Very strange issue which only occurs if using Chrome over a Windows Terminal Services or Remote Desktop session. (I've not tested other operating systems) Our users started complaining this morning that when printing they were seeing large spaces in a report. I tried it on my machine and it worked fine. We were using the same version of Chrome - 54.0.2840.71 m I've created a JSFiddle to demonstrate the issue: https://jsfiddle.net/2dsu99ru/ When printing on a non Terminal Services setup additional spacing is produced in the print. What is the expected result? See comparison of attached PDF's. Please provide any additional information below. Attach a screenshot if possible. Prints attached. I believe this was not working like this in Chrome 53. I've checked on Chrome Canary and the behaviour is still observed.
,
Oct 26 2016
Sidenote... if you change 8.2pt for 10.9px the issue does not appear to present itself - so I think it might be only applicable to points.
,
Oct 26 2016
,
Oct 26 2016
Specifically, you are referring to the "Your laptop ... one of our's" line in the bottom right box, which has odd spacing in Terminal Services JSFiddle.pdf, right?
,
Oct 26 2016
I see this with Remote Desktop. Will bisect. halcanary: Does this look familiar?
,
Oct 26 2016
Bisected to https://chromium.googlesource.com/chromium/src/+log/e55d9d3bf..e58743c43 So probably r406860? Not sure if we want to file this under Blink>Fonts?
,
Oct 27 2016
r406860 was committed in - 54.0.2804.0. Does any one think that this is going to be a stable blocker? We are planning a Stable re-spin today/tomorrow.
,
Oct 27 2016
While annoying for affected users, I don't think this should be a Stable Release Blocker because severity of the bug is not that bad, and the number of affected users is probably not that high.
,
Oct 27 2016
This seems to have something to do with text layout/glyph measurement differences between the remote and the local systems. chrisnevill28@, could you produce smaller PDFs by just highlighting the interesting text and hitting `Ctrl-p`? That'll make it easier to compare just the important differences between the two. Thanks for the bug report.
,
Oct 27 2016
I had no idea you could selectively print like that - learn something every day. Excuse the different account it's the same Chris.
,
Oct 27 2016
Basically for what ever reason it seems to create odd additional spacing on the TS version. In our original reports the spacing appeared in the middle of words, and such like spread across multiple paragraphs.
,
Oct 27 2016
halcanary: Since I can also reproduce it, if there's anything you need, like making a SKP or trying out a patch, let me know.
,
Oct 31 2016
I suspect that SkGlyphCache::getGlyphIDAdvance(gid)::fAdvanceX are different values for the client and the server. thestig@, can you apply https://skia-review.googlesource.com/c/4202/ and see if that fixes anything?
,
Oct 31 2016
May be we should get this fixed before M55 hits stable,tagging accordingly.
,
Oct 31 2016
if it is a release blocker and if https://skia-review.googlesource.com/c/4202/ fixes it, then let's land that for now. It's inefficient, but at least it works. But first, let's hear from Lei.
,
Oct 31 2016
Adding Lei (thestig@), could you ptal comment #13 and #15?
,
Oct 31 2016
halcanary: Yes, the patch fixes it for me via RDP.
,
Nov 1 2016
Mind if I assign this to you? I think I can't help here.
,
Nov 1 2016
Okay. I'm going to land this fix, but it doesn't really address the underlying problem, which seems to be that somewhere someone is getting incorrect typeface metrics.
,
Nov 1 2016
M54 Stable is already deployed today,we should target to M55.
,
Nov 1 2016
Well, we should definitely try merging to M55 first, but we may still want to consider M54 for Terminal Services (i.e. enterprise) users.
,
Nov 1 2016
Please request a merge to M55 ASAP if cl is ready to be merged to M55. Thank you.
,
Nov 2 2016
,
Nov 2 2016
,
Nov 2 2016
Approving merge to M55 branch 2883 based on comment #17 and #21. Please merge ASAP. Thank you.
,
Nov 3 2016
[Automated comment] Request affecting a post-stable build (M54), manual review required.
,
Nov 3 2016
(regarding m54, this cherry-pick - https://skia-review.googlesource.com/c/4343/ - exists, but I don't know how important it is.)
,
Nov 3 2016
,
Nov 3 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by chrisnev...@googlemail.com
, Oct 26 2016