New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659592 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 657959
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Don't create SurfaceFactory lazily, and eliminate "RegisterSurfaceFactoryClient"

Project Member Reported by fsam...@chromium.org, Oct 26 2016

Issue description

There's a lot of seemingly unnecessary complexity surrounding SurfaceFactory.

In particular, a lot of places create SurfaceFactory lazily on SubmitCompositorFrame such as DelegatedFrameHost, RenderWidgetHostViewGuest, RenderWidgetHostViewChildFrame, and destroy them if a context is lost. This seems unnecessarily complex.

SurfaceFactory can simply call RegisterSurfaceFactoryClient/UnregisterSurfaceFactoryClient internally, eliminating the need for public exposure of these methods on SurfaceManager.
 
Owner: mhashmi@chromium.org
Status: Assigned (was: Untriaged)
Mergedinto: 657959
Status: Duplicate (was: Assigned)

Sign in to add a comment