New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659537 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 659168
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

18.2%-18.3% regression in startup.cold.blank_page at 427138:427176

Project Member Reported by alexclarke@chromium.org, Oct 26 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 26 2016

Cc: jam@chromium.org
Owner: jam@chromium.org

=== Auto-CCing suspected CL author jam@chromium.org ===

Hi jam@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Stop running GetAuthTokenFunctionTest as they're failing on debug bots
Author  : jam
Commit description:
  
BUG= 504347 

Review-Url: https://codereview.chromium.org/2449533002
Cr-Commit-Position: refs/heads/master@{#427174}
Commit  : e8d32d3aa2c75cc3b5c7a62c72d3dacb40b0ef41
Date    : Mon Oct 24 22:36:07 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@427137  5595.92  476.939  12  good
chromium@427157  5522.28  182.087  18  good
chromium@427167  5466.33  151.465  12  good
chromium@427172  5507.08  144.36   12  good
chromium@427173  5333.2   50.1767  5   good
chromium@427174  5124.4   127.845  5   bad    <--
chromium@427176  5251.5   193.865  18  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 659537

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests startup.cold.blank_page
Test Metric: foreground_tab_load_complete/foreground_tab_load_complete
Relative Change: 10.53%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6795
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997749421945943184


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5247543120756736

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: ----
That seems unlikely...  Lets try another bisect.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 26 2016

Cc: krasin@chromium.org
Owner: krasin@chromium.org

=== Auto-CCing suspected CL author krasin@chromium.org ===

Hi krasin@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Remove CFI blacklists entries for the fixed bug. (patchset #1 id:1 of https://codereview.chromium.org/2445033002/ )
Author  : krasin
Commit description:
  
Reason for revert:
Broke 'CFI Linux Full' bot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/657/steps/blink_heap_unittests/logs/HeapTest.VectorDestructorsWithVtable

Original issue's description:
> Remove CFI blacklists entries for the fixed bug.
>
> BUG= 568891 
>
> Committed: https://crrev.com/08f73f5e954340b0c0b5e29f75568ffdebb80588
> Cr-Commit-Position: refs/heads/master@{#427126}

TBR=pcc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 568891 

Review-Url: https://codereview.chromium.org/2446803004
Cr-Commit-Position: refs/heads/master@{#427168}
Commit  : 1fd1f5a653e4bebfc481bd7233a5e5418b211ed3
Date    : Mon Oct 24 22:19:23 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@427100  5353.17  418.066  18  good
chromium@427140  5232.44  245.321  18  good
chromium@427160  5217.24  154.257  41  good
chromium@427165  5244.74  101.728  27  good
chromium@427167  5222.83  173.335  12  good
chromium@427168  5435.52  245.633  27  bad    <--
chromium@427170  5317.44  159.956  41  bad
chromium@427180  5375.19  239.052  27  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 659537

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests startup.cold.blank_page
Test Metric: foreground_tab_request_start/foreground_tab_request_start
Relative Change: 5.40%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6796
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997744496195506048


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5798674129485824

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: ----
Hmm that's not right either...
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Oct 26 2016

Mergedinto: 659168
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Initialize buffers before allowing access to them.
Author  : zmo
Commit description:
  
Also, refactor buffer access validation a bit to reduce
duplicated codes.

(Note that this is still part 1 of the work. We have more
buffer access paths that we need to put in buffer access
validation.)

BUG= 654201 
TEST=gpu_unittests, webgl_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2435803004
Cr-Commit-Position: refs/heads/master@{#427200}
Commit  : 26c35c2e81f97a5b291ebd4d639fc3f1a4cc50e8
Date    : Tue Oct 25 01:03:34 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@427000  5192.89  403.802  18  good
chromium@427100  5493.5   400.336  12  good
chromium@427150  5317.83  321.933  12  good
chromium@427175  5685.8   143.663  5   good
chromium@427188  5520.6   103.142  5   good
chromium@427194  5681.0   165.614  5   good
chromium@427197  5668.4   129.406  5   good
chromium@427199  5967.4   198.222  5   good
chromium@427200  4911.61  109.178  18  bad    <--

Bisect job ran on: linux_perf_bisect
Bug ID: 659537

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests startup.cold.blank_page
Test Metric: foreground_tab_request_start/foreground_tab_request_start
Relative Change: 9.11%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6797
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997737456753154000


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5818644922105856

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment