New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659533 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

26.5%-59.1% regression in v8.infinite_scroll-ignition_tbmv2 at 427319:427329

Project Member Reported by alexclarke@chromium.org, Oct 26 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 26 2016

Cc: u...@chromium.org
Owner: u...@chromium.org

=== Auto-CCing suspected CL author ulan@chromium.org ===

Hi ulan@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: failed


===== SUSPECTED CL(s) =====
Subject : Revert of Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcoder… (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2437873004/ )
Author  : ulan
Commit description:
  
Reason for revert:
Canary crashes crbug.com/658718

Original issue's description:
> Reland "[heap] Start sweeper tasks after evacuation. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428043002/ )"
>
> The performance regression in crbug.com/657776 was not caused by this CL.
>
> This reverts commit 4490a7601c81647a4fb93da94360f271eb172473.
>
> BUG=

TBR=mlippautz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2446583003
Cr-Commit-Position: refs/heads/master@{#40539}
Commit  : 59fb09564a81b30f1d37d68c5fa046e609e23927
Date    : Mon Oct 24 16:41:13 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@427318                81.5318  7.83515  5  good
chromium@427324                81.3714  7.48292  5  good
chromium@427327                81.428   2.82842  5  good
chromium@427327,v8@e39a7c7187  82.106   6.018    5  good
chromium@427327,v8@59fb09564a  137.037  7.8894   5  bad    <--
chromium@427327,v8@55277d9969  119.917  17.5545  5  bad
chromium@427327,v8@8f770ad9ec  139.179  8.91985  5  bad
chromium@427328                135.321  11.0084  5  bad
chromium@427329                138.982  5.74753  5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 659533

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.long_running_idle_gmail_tbmv2
Test Metric: v8-gc-total_max/v8-gc-total_max
Relative Change: 70.46%
Score: 98.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/796
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997749510124100928


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5792900418371584

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by u...@chromium.org, Oct 27 2016

Status: Fixed (was: Untriaged)
I relanded the CL. Good to know that it improves performance :)

Sign in to add a comment