New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659528 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

please update clang-format to r284988

Project Member Reported by jochen@chromium.org, Oct 26 2016

Issue description

Comment 1 by thakis@chromium.org, Oct 26 2016

The scripts are very loosely coupled to the binary in our setup... Sounds like just updating the scripts is enough?

Comment 2 by jochen@chromium.org, Oct 26 2016

probably? I don't know... the containing directories README file just pointed at the updating clang-format site

Comment 3 by nick@chromium.org, Oct 26 2016

I'm not set up to roll clang-format at the moment.

Comment 4 by jochen@chromium.org, Oct 27 2016

Cc: nick@chromium.org
Owner: jochen@chromium.org
Status: Fixed (was: Untriaged)
I rolled the scripts only
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fac0bd6133f066f705480405d466bdaae976bf6d

commit fac0bd6133f066f705480405d466bdaae976bf6d
Author: jochen <jochen@chromium.org>
Date: Thu Oct 27 09:02:51 2016

Roll src/buildtools/ 39b1db2ab..1f985091a (1 commit).

https://chromium.googlesource.com/chromium/buildtools.git/+log/39b1db2ab4aa..1f985091a586

$ git log 39b1db2ab..1f985091a --date=short --no-merges --format='%ad %ae %s'
2016-10-27 jochen Roll clang-format 0ed791d..6a413e9

TBR=thakis@chromium.org
BUG= 659528 

Review-Url: https://codereview.chromium.org/2452293003
Cr-Commit-Position: refs/heads/master@{#427973}

[modify] https://crrev.com/fac0bd6133f066f705480405d466bdaae976bf6d/DEPS

Comment 6 by thakis@chromium.org, Oct 27 2016

Awesome, thanks :-)

Comment 7 by thakis@chromium.org, Oct 27 2016

Cc: scottmg@chromium.org
 Issue 651204  has been merged into this issue.

Sign in to add a comment