New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659503 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 655123
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Build ordering or dependency error in extensions

Project Member Reported by suzyh@chromium.org, Oct 26 2016

Issue description

I'm getting a missing-header-file build error if I build chrome, but only if I build blink_tests first.


Steps to reproduce:

Using a gn out directory with no special args:
$ cat out/GnDebug/args.gn
# Build arguments go here. Examples:
#   is_component_build = true
#   is_debug = false
# See "gn args <out_dir> --list" for available build arguments.

1. gn clean out/GnDebug
2. ninja -C out/GnDebug blink_tests
3. ninja -C out/GnDebug chrome


Expected: Builds successfully

Actual:
gn clean; ninja chrome builds successfully.
gn clean; ninja blink_tests; ninja chrome gives a build error on the ninja chrome step:

"""
In file included from ../../extensions/browser/api/bluetooth_low_energy/utils.cc:5:
../../extensions/browser/api/bluetooth_low_energy/utils.h:11:10: fatal error: 'extensions/common/api/bluetooth_low_energy.h' file not found
#include "extensions/common/api/bluetooth_low_energy.h"
"""

Suspecting issue 650835 and https://codereview.chromium.org/2370373002, I checked out the revision prior to that patch and re-built. I still get an error under the same circumstances, but the error is different:

"""
In file included from ../../extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:18:
In file included from ../../extensions/browser/api/extensions_api_client.h:12:
In file included from ../../extensions/browser/api/declarative_content/content_rules_registry.h:12:
../../extensions/browser/api/declarative/rules_registry.h:24:10: fatal error: 'extensions/common/api/events.h' file not found
#include "extensions/common/api/events.h"
"""
 

Comment 1 by st...@chromium.org, Oct 26 2016

Cc: -st...@chromium.org xiy...@chromium.org rdevlin....@chromium.org
Labels: -Pri-3 Pri-2
Owner: st...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by st...@chromium.org, Oct 26 2016

Components: -Platform>Extensions Platform>Apps
Cc: tsniatow...@opera.com
See also https://codereview.chromium.org/2452943003/, issue 655123.  Seems related.
Correct, this is one of the problems listed in issue 655123, file attached there contains a:

Missing non-depfile dependency for obj/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy/utils.o:
gen/extensions/common/api/bluetooth_low_energy.h

the linked CL fixes it and a bunch of other header generator deps in extensions.

Comment 5 by st...@chromium.org, Oct 26 2016

Mergedinto: 655123
Status: Duplicate (was: Assigned)
Cool, merging this issue then.

Comment 6 by st...@chromium.org, Mar 3 2017

Owner: r...@chromium.org

Sign in to add a comment