New issue
Advanced search Search tips

Issue 659468 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in FX_AllocOrDie

Project Member Reported by ClusterFuzz, Oct 26 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5248073623404544

Fuzzer: libfuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  FX_AllocOrDie
  CPDF_SecurityHandler::AES256_CheckPassword
  CPDF_SecurityHandler::CheckPassword
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=395675:395769

Minimized Testcase (1.97 Kb): https://cluster-fuzz.appspot.com/download/AMIfv949EXLVC3CvmgigpRCWUYsdoUXE9W1wnUcGfRggRqtEdsOJD8W0C4hRf4xfjkvy2ntn_qfZNjcfzbvyomtvjDacuhSV2vanwVAVb2-nJx3VQF-qhERdekEAvxYGraAgegR9B75njJbIBBvbzuoftDV1Al4M2Q?testcase_id=5248073623404544

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
dsinclair @ could you please look into this.please feel free to re-assigned back if needed. thanks in advance !
Components: Internals>Plugins>PDF
Owner: thestig@chromium.org
Status: Started (was: Assigned)
This one is easy, so I'll grab it. :) https://codereview.chromium.org/2463183002
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/a3580f9fb0eb11f7a501a28be953ff948c28ce06

commit a3580f9fb0eb11f7a501a28be953ff948c28ce06
Author: thestig <thestig@chromium.org>
Date: Mon Oct 31 20:06:39 2016

Fix a memory leak in CPDF_SecurityHandler.

AES256_CheckPassword() leaks memory on failure.
Clean up some nits.

BUG= chromium:659468 

Review-Url: https://codereview.chromium.org/2463183002

[modify] https://crrev.com/a3580f9fb0eb11f7a501a28be953ff948c28ce06/core/fpdfapi/parser/cpdf_security_handler.cpp

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345df4129bf17969991b958d95ef8e90e78a1083

commit 345df4129bf17969991b958d95ef8e90e78a1083
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Mon Oct 31 22:19:22 2016

Roll src/third_party/pdfium/ 96c7b3351..da4ff18a7 (4 commits).

https://pdfium.googlesource.com/pdfium.git/+log/96c7b33510c5..da4ff18a7dd2

$ git log 96c7b3351..da4ff18a7 --date=short --no-merges --format='%ad %ae %s'
2016-10-31 weili Update document with supported architecture information
2016-10-31 thestig Fix a memory leak in CPDF_SecurityHandler.
2016-10-31 dsinclair Remove GetWidget() overrides
2016-10-31 art-snake Fix loading page using hint tables. When linearized document have hint table, The FPDFAvail_IsPageAvail return true, but FPDF_LoadPage return nullptr, for non first pages.

BUG= 659468 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2470523002
Cr-Commit-Position: refs/heads/master@{#428838}

[modify] https://crrev.com/345df4129bf17969991b958d95ef8e90e78a1083/DEPS

Project Member

Comment 7 by ClusterFuzz, Nov 1 2016

ClusterFuzz has detected this issue as fixed in range 428777:428862.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5248073623404544

Fuzzer: libfuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  FX_AllocOrDie
  CPDF_SecurityHandler::AES256_CheckPassword
  CPDF_SecurityHandler::CheckPassword
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=395675:395769
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=428777:428862

Minimized Testcase (1.97 Kb): https://cluster-fuzz.appspot.com/download/AMIfv949EXLVC3CvmgigpRCWUYsdoUXE9W1wnUcGfRggRqtEdsOJD8W0C4hRf4xfjkvy2ntn_qfZNjcfzbvyomtvjDacuhSV2vanwVAVb2-nJx3VQF-qhERdekEAvxYGraAgegR9B75njJbIBBvbzuoftDV1Al4M2Q?testcase_id=5248073623404544

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment