New issue
Advanced search Search tips

Issue 659467 link

Starred by 1 user
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Dec 2016
Cc:
toyoshim@chromium.org
esprehn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean-up Blink's MIME registry impl

Project Member Reported by kinuko@chromium.org, Oct 26 2016 
1. WebMimeRegistry implementation can be moved into blink (a la onion soup)
2. We can actually likely remove the public interface too
3. WebMimeRegistry code can be merged with MIMETypeRegistry
4. All Mime code should be in its own subdirectory, current suggestion is to move it under network/mime

Comment 1 by kinuko@chromium.org, Nov 5 2016

Components: Blink>Internals>Modularization
For reference, current plan for network / loading related platform files: https://docs.google.com/spreadsheets/d/1caEsYrkqC2D0iHmnf9-Mwi1VIwYIUjs5WU9FZciYeUg/edit#gid=0
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67437352849b595c1c3a20ced14c2be67bcea8e2

commit 67437352849b595c1c3a20ced14c2be67bcea8e2
Author: kinuko <kinuko@chromium.org>
Date: Sat Nov 05 02:40:37 2016

Move WebMIMERegistry impl from //content to blink:platform/network/mime

This change does:
- Remove WebMIMERegistry from Platform interface
- Merge WebMIMERegistry impl into blink::MIMETypeRegistry
- Move MIMETypeRegistry.cpp into network/mime (for cleaner DEPS)

I will move MIMETypeRegistry.h and other mime-related files into the
same directory in a follow-up patch.

BUG=561879, 659467 

Review-Url: https://codereview.chromium.org/2444873002
Cr-Commit-Position: refs/heads/master@{#430130}

[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/child/BUILD.gn
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/child/assert_matching_enums.cc
[delete] https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0/content/child/simple_webmimeregistry_impl.cc
[delete] https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0/content/child/simple_webmimeregistry_impl.h
[delete] https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0/content/child/simple_webmimeregistry_impl_unittest.cc
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/ppapi_plugin/ppapi_blink_platform_impl.cc
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/ppapi_plugin/ppapi_blink_platform_impl.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/test/BUILD.gn
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0/third_party/WebKit/Source/platform/MIMETypeRegistry.cpp
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/MIMETypeRegistry.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/network/DEPS
[add] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp
[add] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistryTest.cpp
[add] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/network/mime/MockMimeRegistry.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/67437352849b595c1c3a20ced14c2be67bcea8e2/third_party/WebKit/public/platform/Platform.h
[delete] https://crrev.com/0292659d45ce31e698ea8329f8aef66c8ac1c9e0/third_party/WebKit/public/platform/WebMimeRegistry.h

Comment 3 by kinuko@chromium.org, Dec 7 2016

Cc: toyoshim@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58

commit 97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58
Author: kinuko <kinuko@chromium.org>
Date: Wed Dec 07 16:35:44 2016

Move MIME related platform files under network/mime

* MIMETypeRegistry.cpp
* MIMETypeFromURL.{cpp,h}
* ContentType.{cpp,h}

Follow-up for crrev.com/2444873002

BUG= 659467 

Review-Url: https://codereview.chromium.org/2482653002
Cr-Commit-Position: refs/heads/master@{#436977}

[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/dom/DOMImplementation.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/fileapi/File.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/LinkStyle.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/image-encoders/ImageEncoderUtils.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
[rename] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/ContentType.cpp
[rename] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/ContentType.h
[rename] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/MIMETypeFromURL.cpp
[rename] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/MIMETypeFromURL.h
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp
[rename] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.h
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistryTest.cpp
[modify] https://crrev.com/97c9fecf4a50dd69ccf162aa1c75c7f40cdbbf58/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Comment 5 by kinuko@chromium.org, Dec 9 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment