New issue
Advanced search Search tips

Issue 659464 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove (Unicode) case-insensitive matching for usemap attribute

Project Member Reported by tkent@chromium.org, Oct 26 2016

Issue description

In https://bugs.chromium.org/p/chromium/issues/detail?id=639477 the use counters have come back for the strange Unicode case-insensitive matching used by these constructs: radio button groups, <img usemap>, and <object usemap>. The results were that the Unicode code path was never triggered and the ASCII case-insensitive code path was triggered on <0.0001% of pages.

As such, we changed the spec in https://github.com/whatwg/html/commit/6acdb2122298d2bb7bb839c0a61b4e1f9b0f9bc9 to use simple case-sensitive matching for these strings (which should be treated as identifiers anyway). Web platform tests are available at:

- http://w3c-test.org/html/semantics/embedded-content/the-img-element/usemap-casing.html
- http://w3c-test.org/html/semantics/embedded-content/the-object-element/usemap-casing.html

(copied from  Issue 658749 )

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5cd3470950e29229752c7d239ad4a5c9fe18598

commit b5cd3470950e29229752c7d239ad4a5c9fe18598
Author: tkent <tkent@chromium.org>
Date: Fri Nov 18 09:32:41 2016

Deprecate case-insensitive matching for |usemap| attribute

This CL doesn't use Deprecation::countDeprecation() because we'd like to show a
deprecation warning message once per a pair of names. This CL uses FrameConsole::
addSingletonMesssage().

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8pHdFzN0YQc

BUG= 659464 

Review-Url: https://codereview.chromium.org/2501893003
Cr-Commit-Position: refs/heads/master@{#433159}

[modify] https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598/third_party/WebKit/LayoutTests/images/image-map-multiple-expected.txt
[modify] https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt
[modify] https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598/third_party/WebKit/LayoutTests/platform/mac/images/imagemap-case-expected.txt
[modify] https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 3 by tkent@chromium.org, Nov 21 2016

Labels: -Needs-BlinkIntent
Owner: tkent@chromium.org
Status: Assigned (was: Available)

Comment 4 by tkent@chromium.org, Jan 23 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc5978539854826253e97b7c2e4be61a73a2153

commit dcc5978539854826253e97b7c2e4be61a73a2153
Author: tkent <tkent@chromium.org>
Date: Mon Jan 23 06:46:47 2017

Remove case-insensitive matching of usemap attribute.

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8pHdFzN0YQc

BUG= 659464 

Review-Url: https://codereview.chromium.org/2648163002
Cr-Commit-Position: refs/heads/master@{#445328}

[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/image-maps/image-map-processing-model/hash-name-reference-expected.txt
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/LayoutTests/images/image-map-multiple-expected.txt
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/LayoutTests/images/image-map-multiple.html
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/images/imagemap-case.html
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/platform/linux/images/imagemap-case-expected.png
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/platform/linux/images/imagemap-case-expected.txt
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/platform/mac/images/imagemap-case-expected.png
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/platform/mac/images/imagemap-case-expected.txt
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/platform/win/images/imagemap-case-expected.png
[delete] https://crrev.com/206f85553b9078dceb144cff4c4becb13f73624a/third_party/WebKit/LayoutTests/platform/win/images/imagemap-case-expected.txt
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/Source/core/dom/DocumentOrderedMap.h
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/dcc5978539854826253e97b7c2e4be61a73a2153/third_party/WebKit/Source/core/html/HTMLMapElement.cpp

Comment 6 by tkent@chromium.org, Jan 23 2017

Labels: M-58
Status: Fixed (was: Started)

Sign in to add a comment