New issue
Advanced search Search tips

Issue 659458 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Revert "Enable MidiManagerWinrt by default on Windows 10" (crbug.com/645403)

Project Member Reported by shaochuan@chromium.org, Oct 26 2016

Issue description

It's observed that new APIs doesn't work well with major third-party device drivers and applications that still uses old APIs. See https://bugs.chromium.org/p/chromium/issues/detail?id=645403#c8 for more details.

We revert the CL to make the new WebMIDI backend back behind a Finch flag disabled by default, and should not reland until major third-party providers begin supporting new APIs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d340033715f50c38b75b4cbaa06b7445411869c

commit 2d340033715f50c38b75b4cbaa06b7445411869c
Author: shaochuan <shaochuan@chromium.org>
Date: Sat Oct 29 07:26:00 2016

Revert "Enable MidiManagerWinrt by default on Windows 10"

Make MidiManagerWinrt back behind a Finch flag disabled by default.

Reverting CL https://codereview.chromium.org/2392263002/ while preserving
strings and histograms for the "disabled" flag. Revert this CL to enable it by
default again.

BUG= 645403 , 659458 

Review-Url: https://codereview.chromium.org/2450033003
Cr-Commit-Position: refs/heads/master@{#428608}

[modify] https://crrev.com/2d340033715f50c38b75b4cbaa06b7445411869c/chrome/app/generated_resources.grd
[modify] https://crrev.com/2d340033715f50c38b75b4cbaa06b7445411869c/chrome/browser/about_flags.cc
[modify] https://crrev.com/2d340033715f50c38b75b4cbaa06b7445411869c/media/midi/midi_manager_win.cc
[modify] https://crrev.com/2d340033715f50c38b75b4cbaa06b7445411869c/media/midi/midi_switches.cc
[modify] https://crrev.com/2d340033715f50c38b75b4cbaa06b7445411869c/media/midi/midi_switches.h

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 30 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 4 Deleted

Please merge your change to M55 branch 2883 ASAP. If merge happens before 5:00 PM PT today, Tuesday (11/01/16), then we can pick it up for this week Beta release. Thank you.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 2 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 7 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7

commit b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7
Author: shaochuan <shaochuan@chromium.org>
Date: Mon Nov 07 06:37:42 2016

Revert "Enable MidiManagerWinrt by default on Windows 10"

Make MidiManagerWinrt back behind a Finch flag disabled by default.

Reverting CL https://codereview.chromium.org/2392263002/ while preserving
strings and histograms for the "disabled" flag. Revert this CL to enable it by
default again.

BUG= 645403 , 659458 
TBR=shaochuan@chromium.org,toyoshim@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2462383002
Cr-Commit-Position: refs/branch-heads/2883@{#473}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7/chrome/app/generated_resources.grd
[modify] https://crrev.com/b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7/chrome/browser/about_flags.cc
[modify] https://crrev.com/b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7/media/midi/midi_manager_win.cc
[modify] https://crrev.com/b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7/media/midi/midi_switches.cc
[modify] https://crrev.com/b98ddc5d66411ec00f4bc597a5e4aac0ca9dd0a7/media/midi/midi_switches.h

Status: Fixed (was: Started)

Sign in to add a comment