New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 659449 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Predator] Refactor GitRepository to make http_client required argument.

Project Member Reported by kateso...@chromium.org, Oct 26 2016

Issue description

[Predator] Refactor GitRepository to make http_client required argument.
 
Components: Tools>Test>Predator
Components: -Tools>Test>FindIt>Crash
Cc: chanli@chromium.org lijeffrey@chromium.org
 Issue 659791  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/cae4d6478d25b9be3607bb20989713569eae9c49

commit cae4d6478d25b9be3607bb20989713569eae9c49
Author: katesonia <katesonia@chromium.org>
Date: Tue Nov 29 19:32:29 2016

[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

BUG= 659449 

Review-Url: https://codereview.chromium.org/2524633002

[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/crash/crash_pipeline.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/crash/test/changelist_classifier_test.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/crash/test/findit_for_chromecrash_test.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/handlers/crash/crash_handler.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/handlers/help_triage.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/lib/gitiles/gitiles_repository.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/lib/gitiles/test/gitiles_repository_test.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/waterfall/build_failure_analysis.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/waterfall/extract_deps_info_pipeline.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/waterfall/pull_changelog_pipeline.py
[modify] https://crrev.com/cae4d6478d25b9be3607bb20989713569eae9c49/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

Status: Fixed (was: Assigned)

Sign in to add a comment