New issue
Advanced search Search tips

Issue 659448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 604282



Sign in to add a comment

Clean up obsolete parts of //ipc

Project Member Reported by sa...@chromium.org, Oct 26 2016

Issue description

Once ChannelMojo is the only Channel in use, parts of //ipc will be obsolete. This bug tracks cleaning up //ipc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d45a95a8ac88b71b768a850cbeffc2c318a10cf9

commit d45a95a8ac88b71b768a850cbeffc2c318a10cf9
Author: sammc <sammc@chromium.org>
Date: Wed Oct 26 07:15:43 2016

Change most IPC tests to use ChannelMojo.

Most IPC::Channels in production are now ChannelMojo, but most tests
use the platform-specific Channel implementations. This changes the IPC
tests other than IPCMultiSendingFdsTest.StressTest and those in
ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use
ChannelMojo.

BUG= 659448 

Review-Url: https://codereview.chromium.org/2451953003
Cr-Commit-Position: refs/heads/master@{#427624}

[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/BUILD.gn
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/DEPS
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_channel_proxy_unittest.cc
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_fuzzing_tests.cc
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_send_fds_test.cc
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_sync_channel_unittest.cc
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_test_base.cc
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/ipc_test_base.h
[modify] https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9/ipc/sync_socket_unittest.cc

Comment 2 by foolip@chromium.org, Oct 26 2016

Sheriff here. I reverted this in https://codereview.chromium.org/2455583002/, this is the failure output:

IPCChannelBadMessageTest.BadMessage (run #1):
[ RUN      ] IPCChannelBadMessageTest.BadMessage
[27757:27757:1026/012625:13499281319:WARNING:test_suite.cc(211)] Test launcher output path /tmp/.org.chromium.Chromium.1uEQLi/test_results.xml exists. Not adding test launcher result printer.
IPCChannelBadMessageTest.BadMessage (run #2):
[ RUN      ] IPCChannelBadMessageTest.BadMessage
[28221:28221:1026/013355:13949300379:WARNING:test_suite.cc(211)] Test launcher output path /tmp/.org.chromium.Chromium.mLsERR/test_results.xml exists. Not adding test launcher result printer.
IPCChannelBadMessageTest.BadMessage (run #3):
[ RUN      ] IPCChannelBadMessageTest.BadMessage
[28242:28242:1026/013440:13994308371:WARNING:test_suite.cc(211)] Test launcher output path /tmp/.org.chromium.Chromium.u7Jqjz/test_results.xml exists. Not adding test launcher result printer.
IPCChannelBadMessageTest.BadMessage (run #4):
[ RUN      ] IPCChannelBadMessageTest.BadMessage
[28265:28265:1026/013525:14039311466:WARNING:test_suite.cc(211)] Test launcher output path /tmp/.org.chromium.Chromium.fof9IJ/test_results.xml exists. Not adding test launcher result printer.

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/010a37c4fcb585575418ea0b0c80cdb97e46fe9e

commit 010a37c4fcb585575418ea0b0c80cdb97e46fe9e
Author: foolip <foolip@chromium.org>
Date: Wed Oct 26 08:57:33 2016

Revert of Change most IPC tests to use ChannelMojo. (patchset #1 id:100001 of https://codereview.chromium.org/2451953003/ )

Reason for revert:
IPCChannelBadMessageTest.BadMessage is failing on Ubuntu-12.04.

Original issue's description:
> Change most IPC tests to use ChannelMojo.
>
> Most IPC::Channels in production are now ChannelMojo, but most tests
> use the platform-specific Channel implementations. This changes the IPC
> tests other than IPCMultiSendingFdsTest.StressTest and those in
> ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use
> ChannelMojo.
>
> BUG= 659448 
>
> Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9
> Cr-Commit-Position: refs/heads/master@{#427624}

TBR=rockot@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659448 

Review-Url: https://codereview.chromium.org/2455583002
Cr-Commit-Position: refs/heads/master@{#427642}

[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/BUILD.gn
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/DEPS
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_channel_proxy_unittest.cc
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_fuzzing_tests.cc
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_send_fds_test.cc
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_sync_channel_unittest.cc
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_test_base.cc
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/ipc_test_base.h
[modify] https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e/ipc/sync_socket_unittest.cc

Comment 4 by foolip@chromium.org, Oct 26 2016

The same failure was also happening on Linux ChromiumOS.

Comment 5 by foolip@chromium.org, Oct 26 2016

On Windows-7-SP1 it was a timeout of another test, but likely same root cause:
[73/74] IPCSyncChannelTest.ChattyServer (TIMED OUT)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0

commit 4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0
Author: sammc <sammc@chromium.org>
Date: Wed Oct 26 21:07:11 2016

Remove uses of AttachmentBroker from //content and //components/nacl.

The browser process and its descendents now use ChannelMojo for all
Channels; ChannelMojo relies on the underlying mojo message pipe to pass
attachments over a channel. Therefore, AttachmentBroker is no longer
needed ther. This CL removes all use of AttachmentBroker from the
browser process and its descendents.

BUG= 659448 

Review-Url: https://codereview.chromium.org/2434103002
Cr-Commit-Position: refs/heads/master@{#427786}

[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/components/nacl/broker/nacl_broker_listener.cc
[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/content/child/child_thread_impl.cc
[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/content/common/child_process_host_impl.cc
[modify] https://crrev.com/4efdde648cb5c1ef69aa1a03c72761bd18d7a4d0/content/public/common/child_process_host.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2824a6d83cff43802ae1cc0dba4d4613b1bd887

commit e2824a6d83cff43802ae1cc0dba4d4613b1bd887
Author: sammc <sammc@chromium.org>
Date: Wed Oct 26 22:33:59 2016

Remove use of ChannelHandle::name from gpu/ipc/service.

ChannelHandle will soon only support mojo handles. This CL removes use
of the fields that will be removed in gpu/ipc/service.

BUG= 659448 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2448973003
Cr-Commit-Position: refs/heads/master@{#427852}

[modify] https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887/gpu/ipc/service/gpu_channel.h
[modify] https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887/gpu/ipc/service/gpu_channel_manager_unittest.cc
[modify] https://crrev.com/e2824a6d83cff43802ae1cc0dba4d4613b1bd887/gpu/ipc/service/gpu_channel_test_common.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1

commit 4bcc4ed62e7c10652053462cee1016ff1d7b8cb1
Author: sammc <sammc@chromium.org>
Date: Thu Oct 27 10:13:59 2016

Change most IPC tests to use ChannelMojo.

Most IPC::Channels in production are now ChannelMojo, but most tests
use the platform-specific Channel implementations. This changes the IPC
tests other than IPCMultiSendingFdsTest.StressTest and those in
ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use
ChannelMojo.

BUG= 659448 

Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9
Review-Url: https://codereview.chromium.org/2451953003
Cr-Original-Commit-Position: refs/heads/master@{#427624}
Cr-Commit-Position: refs/heads/master@{#427988}

[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/BUILD.gn
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/DEPS
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_channel_proxy_unittest.cc
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_fuzzing_tests.cc
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_send_fds_test.cc
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_sync_channel_unittest.cc
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_test_base.cc
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/ipc_test_base.h
[modify] https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1/ipc/sync_socket_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c4919ce22c529fd2b0207142a62c9184adb2573

commit 0c4919ce22c529fd2b0207142a62c9184adb2573
Author: sammc <sammc@chromium.org>
Date: Tue Nov 01 01:37:16 2016

Remove uses of ChannelHandle for service processes.

ChannelHandle will soon only support mojo handles. In preparation for
this, this CL changes service process uses of ChannelHandle that relied
on the storage of pipe/socket names or file descriptors to use mojo
embedder types appropriate for each use.

BUG= 659448 

Review-Url: https://codereview.chromium.org/2444363003
Cr-Commit-Position: refs/heads/master@{#428906}

[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/browser/service_process/service_process_control.cc
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/BUILD.gn
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/DEPS
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/service_process_util.cc
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/service_process_util.h
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/service_process_util_linux.cc
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/service_process_util_mac.mm
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/common/service_process_util_win.cc
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/service/service_ipc_server.h
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/service/service_ipc_server_unittest.cc
[modify] https://crrev.com/0c4919ce22c529fd2b0207142a62c9184adb2573/chrome/service/service_process.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beeed368eb1ac5c097162ad4f6e36d012ee88a53

commit beeed368eb1ac5c097162ad4f6e36d012ee88a53
Author: sammc <sammc@chromium.org>
Date: Tue Nov 08 23:24:35 2016

Delete IPC::ChannelPosix, IPC::ChannelWin and IPC::AttachmentBroker.

BUG= 659448 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2473993003
Cr-Commit-Position: refs/heads/master@{#430753}

[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/blimp/test/fake_engine/BUILD.gn
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/blimp/test/fake_engine/fake_engine_app_tests.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/content/renderer/render_widget.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/BUILD.gn
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/DEPS
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_mac_unittest.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_messages.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged_mac.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged_mac.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged_mac_unittest.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged_win.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged_win.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_privileged_win_unittest.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_unprivileged.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_unprivileged.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_unprivileged_mac.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_unprivileged_mac.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_unprivileged_win.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/attachment_broker_unprivileged_win.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/brokerable_attachment.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/brokerable_attachment.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/brokerable_attachment_mac.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/brokerable_attachment_win.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/handle_attachment_win.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/handle_attachment_win.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_common.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_factory.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_nacl.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_channel_posix.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_channel_posix.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_channel_posix_unittest.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_reader.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_reader.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_channel_reader_unittest.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_channel_unittest.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_channel_win.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_channel_win.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message_attachment_set.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message_attachment_set.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_message_generator.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_message_generator.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message_unittest.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message_utils.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_message_utils.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_mojo_perftest.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_multiprocess_test.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_multiprocess_test.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_perftest_support.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_perftest_support.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/ipc_perftests.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_send_fds_test.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_test_base.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/ipc_test_base.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/mach_port_attachment_mac.cc
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ipc/mach_port_attachment_mac.h
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/placeholder_brokerable_attachment.cc
[delete] https://crrev.com/ffdf4fbbd03f6594cea91e5e8f772ca550cc8de1/ipc/placeholder_brokerable_attachment.h
[modify] https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53/ppapi/proxy/plugin_dispatcher.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468

commit 19eb6f7cc2ca4b1064781d73f6f74a9d114a9468
Author: sammc <sammc@chromium.org>
Date: Wed Nov 09 21:24:13 2016

Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG= 659448 

Review-Url: https://codereview.chromium.org/2476883002
Cr-Commit-Position: refs/heads/master@{#431036}

[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/components/nacl/loader/nacl_ipc_adapter.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/app/content_main_runner.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/browser/child_process_launcher.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/browser/child_process_launcher.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/common/child_process_host_impl.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/common/child_process_host_impl.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/common/zygote_commands_linux.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/public/common/child_process_host.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/public/common/sandboxed_process_launcher_delegate.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/content/zygote/zygote_linux.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel_mojo.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel_nacl.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel_proxy.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_channel_proxy.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_descriptors.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_test_sink.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ipc/ipc_test_sink.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ppapi/proxy/proxy_channel.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ppapi/proxy/proxy_channel.h
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468/ui/ozone/public/ozone_gpu_test_helper.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f810f07f1eed49e3a197ca2bf2188222c5244908

commit f810f07f1eed49e3a197ca2bf2188222c5244908
Author: sammc <sammc@chromium.org>
Date: Thu Nov 10 22:34:07 2016

Remove IPC::Endpoint.

BUG= 659448 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2493623002
Cr-Commit-Position: refs/heads/master@{#431381}

[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/content/renderer/pepper/renderer_ppapi_host_impl.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/gpu/ipc/service/gpu_channel.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/BUILD.gn
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_common.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_mojo.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_nacl.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_proxy.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_proxy.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_reader.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_reader.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_channel_reader_unittest.cc
[delete] https://crrev.com/273cccbc60b358d06c332f64a8b3cc9f5ee42dd6/ipc/ipc_endpoint.cc
[delete] https://crrev.com/273cccbc60b358d06c332f64a8b3cc9f5ee42dd6/ipc/ipc_endpoint.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_message.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_message.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_message_pipe_reader.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_message_pipe_reader.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_test_sink.cc
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ipc/ipc_test_sink.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ppapi/proxy/proxy_channel.h
[modify] https://crrev.com/f810f07f1eed49e3a197ca2bf2188222c5244908/ui/ozone/public/ozone_gpu_test_helper.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf370c24d97be78187311bb28bc3275a1195024

commit 9bf370c24d97be78187311bb28bc3275a1195024
Author: sammc <sammc@chromium.org>
Date: Mon Nov 14 03:29:08 2016

Remove unused parts of IPC::ChannelHandle.

In SFI NaCl, ChannelHandle is just a file descriptor. On other platforms
it's just a mojo message pipe handle. This CL removes the other unused
fields. It also removes IPC::Channel::GenerateMojoChannelHandlePair()
and updates its remaining use.

BUG= 659448 

Review-Url: https://codereview.chromium.org/2484943004
Cr-Commit-Position: refs/heads/master@{#431821}

[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/android_webview/browser/aw_printing_message_filter.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/android_webview/browser/aw_printing_message_filter.h
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_channel.h
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_channel_common.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_channel_handle.h
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_channel_nacl.h
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_message_utils.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ipc/ipc_message_utils_unittest.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ppapi/nacl_irt/irt_start.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/ppapi/proxy/ppapi_proxy_test.cc
[modify] https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024/tools/ipc_fuzzer/fuzzer/fuzzer.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56

commit f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Author: sammc <sammc@chromium.org>
Date: Tue Nov 15 09:46:49 2016

Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG= 659448 

Review-Url: https://codereview.chromium.org/2494943002
Cr-Commit-Position: refs/heads/master@{#432153}

[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/base/pickle.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/BUILD.gn
[delete] https://crrev.com/054c00dbda1b140444adfe0cdf4e9ad76739c9c3/ipc/brokerable_attachment.cc
[delete] https://crrev.com/054c00dbda1b140444adfe0cdf4e9ad76739c9c3/ipc/brokerable_attachment.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/handle_attachment_win.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/handle_attachment_win.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/handle_win.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_nacl.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_reader.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_reader.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_channel_reader_unittest.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message_attachment.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message_attachment_set.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message_attachment_set.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message_attachment_set_posix_unittest.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message_utils.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_message_utils.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_mojo_handle_attachment.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_mojo_handle_attachment.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_mojo_message_helper.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_platform_file_attachment_posix.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/ipc_platform_file_attachment_posix.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/mach_port_attachment_mac.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/mach_port_attachment_mac.h
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ipc/mach_port_mac.cc
[modify] https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56/ppapi/proxy/nacl_message_scanner.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff1de9d81338681be3687697038553691b52c88

commit cff1de9d81338681be3687697038553691b52c88
Author: horo <horo@chromium.org>
Date: Wed Nov 16 01:52:54 2016

Revert of Remove IPC::BrokerableAttachment. (patchset #1 id:120001 of https://codereview.chromium.org/2494943002/ )

Reason for revert:
Caused crash in NewlibPackagedAppTest.SuccessfulLoad browser_tests.

See  http://crbug.com/665678#c1 

BUG= 665678 

Original issue's description:
> Remove IPC::BrokerableAttachment.
>
> With only ChannelMojo in use, the distinction between brokerable and
> non-brokerable attachments no longer makes sense. This CL removes that
> distinction by removing BrokerableAttachment and flattening the
> hierarchy of attachment types.
>
> This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.
>
> BUG= 659448 
>
> Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
> Cr-Commit-Position: refs/heads/master@{#432153}

TBR=rockot@chromium.org,dcheng@chromium.org,mseaborn@chromium.org,raymes@chromium.org,erikchen@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659448 

Review-Url: https://codereview.chromium.org/2504063002
Cr-Commit-Position: refs/heads/master@{#432351}

[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/base/pickle.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/BUILD.gn
[add] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/brokerable_attachment.cc
[add] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/brokerable_attachment.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/handle_attachment_win.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/handle_attachment_win.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/handle_win.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_nacl.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_reader.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_reader.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_channel_reader_unittest.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message_attachment.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message_attachment_set.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message_attachment_set.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message_attachment_set_posix_unittest.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message_utils.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_message_utils.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_mojo_handle_attachment.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_mojo_handle_attachment.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_mojo_message_helper.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_platform_file_attachment_posix.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/ipc_platform_file_attachment_posix.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/mach_port_attachment_mac.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/mach_port_attachment_mac.h
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ipc/mach_port_mac.cc
[modify] https://crrev.com/cff1de9d81338681be3687697038553691b52c88/ppapi/proxy/nacl_message_scanner.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde36206b72b750f08a91a6ff4c50a9e269b8362

commit cde36206b72b750f08a91a6ff4c50a9e269b8362
Author: sammc <sammc@chromium.org>
Date: Wed Nov 23 02:33:57 2016

Remove ipc/unix_domain_socket_util.*

BUG= 659448 

Review-Url: https://codereview.chromium.org/2500263004
Cr-Commit-Position: refs/heads/master@{#434089}

[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/chrome/common/DEPS
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/chrome/common/service_process_util_mac.mm
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/components/arc/BUILD.gn
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/components/arc/DEPS
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/components/arc/arc_session.cc
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/components/exo/wayland/DEPS
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/components/exo/wayland/server.cc
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/ipc/BUILD.gn
[delete] https://crrev.com/3712de4fe0f696d46aba8ae9fb22658fc116596f/ipc/unix_domain_socket_util.cc
[delete] https://crrev.com/3712de4fe0f696d46aba8ae9fb22658fc116596f/ipc/unix_domain_socket_util.h
[delete] https://crrev.com/3712de4fe0f696d46aba8ae9fb22658fc116596f/ipc/unix_domain_socket_util_unittest.cc
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/mojo/edk/embedder/named_platform_handle_utils.h
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/mojo/edk/embedder/named_platform_handle_utils_posix.cc
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/mojo/edk/embedder/platform_channel_utils_posix.cc
[modify] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/mojo/edk/embedder/platform_channel_utils_posix.h

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d

commit 6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d
Author: sammc <sammc@chromium.org>
Date: Wed Nov 23 03:17:35 2016

Remove IPC::BrokerableAttachment.

With only ChannelMojo in use, the distinction between brokerable and
non-brokerable attachments no longer makes sense. This CL removes that
distinction by removing BrokerableAttachment and flattening the
hierarchy of attachment types.

This also trims some POSIX-specific parts of IPC::MessageAttachmentSet.

BUG= 659448 

Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56
Review-Url: https://codereview.chromium.org/2494943002
Cr-Original-Commit-Position: refs/heads/master@{#432153}
Cr-Commit-Position: refs/heads/master@{#434099}

[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/base/pickle.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/BUILD.gn
[delete] https://crrev.com/9be83c0490323e941cabd41da1edf5b6079a954b/ipc/brokerable_attachment.cc
[delete] https://crrev.com/9be83c0490323e941cabd41da1edf5b6079a954b/ipc/brokerable_attachment.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/handle_attachment_win.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/handle_attachment_win.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/handle_win.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_mojo.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_nacl.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_nacl.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_reader.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_reader.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_channel_reader_unittest.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message_attachment.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message_attachment_set.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message_attachment_set.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message_attachment_set_posix_unittest.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message_utils.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_message_utils.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_mojo_handle_attachment.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_mojo_handle_attachment.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_mojo_message_helper.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_platform_file_attachment_posix.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_platform_file_attachment_posix.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/ipc_send_fds_test.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/mach_port_attachment_mac.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/mach_port_attachment_mac.h
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ipc/mach_port_mac.cc
[modify] https://crrev.com/6ed3efbc2e55eb7aaae5520b9a7bceeacd3faa0d/ppapi/proxy/nacl_message_scanner.cc

Comment 20 by sa...@chromium.org, Jan 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment