language_detection.js and translate_ios.js do not allow turning on --jscomp_error=checkTypes |
||||||||||||
Issue description
App Version (from "Chrome Settings > About Chrome"): ToT
Steps to reproduce:
1. Open language_detection.js and translate_ios.js
2. Remove @suppress {checkTypes}
3. Build Chrome for iOS
Actual result:
Closure compilation fails
,
Oct 26 2016
I wrote those files, but I don't remember much about them. Seems related to bug 487804, assigning to Eugene.
,
Oct 26 2016
,
Oct 26 2016
Bug 647084 may also be related.
,
Oct 26 2016
Does not block 487804. 487804 will be fixed in https://codereview.chromium.org/2449333002/ This very bug is related mostly to usage of unknown cr global object and was created just to add a TODO. Once cl/2449333002 is landed this bug can be assigned to appropriate owner and addressed. David, Sylvain, who owns translate_ios.js at this point?
,
Nov 2 2016
I guess Sylvain now owns translate JavaScript files.
,
Apr 18 2017
Sylvain - is this something you're still working on?
,
Apr 27 2017
,
Jun 11 2018
,
Sep 20
,
Oct 29
Bulk assigning iOS-specific Translate bugs to ghendel@ for triage as per our discussion.
,
Nov 2
Noyau@ do you know if there's someone that can own this on your team since Sylvain is no longer on the team?
,
Nov 16
It is probably a good idea to do a pass at those files and clean up the javascript. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by groby@chromium.org
, Oct 26 2016